workflows/build-ci-container: Make sure to only test local containers

[tstellar]

The container test is run before we create the :latest tag, so we should not try testing this, otherwise it will pull the :latest tag from the github registry, and won't test the container we just built.

[llvmbot]

@llvm/pr-subscribers-github-workflow

Author: Tom Stellard (tstellar)

Changes

The container test is run before we create the :latest tag, so we should not try testing this, otherwise it will pull the :latest tag from the github registry, and won't test the container we just built.

---

Full diff: https://github.com/llvm/llvm-project/pull/120827.diff

1 Files Affected:

• (modified) .github/workflows/build-ci-container.yml (+3-2)

diff --git a/.github/workflows/build-ci-container.yml b/.github/workflows/build-ci-container.yml
index 50729e0173506e..4fa0713b381ceb 100644
--- a/.github/workflows/build-ci-container.yml
+++ b/.github/workflows/build-ci-container.yml
@@ -59,8 +59,9 @@ jobs:
 
       - name: Test Container
         run: |
-          for image in ${{ steps.vars.outputs.container-name-tag }} ${{  steps.vars.outputs.container-name }}; do
-            podman run --rm -it $image /usr/bin/bash -x -c 'cd $HOME && printf '\''#include <iostream>\nint main(int argc, char **argv) { std::cout << "Hello\\n"; }'\'' | clang++ -x c++ - && ./a.out | grep Hello'
+          for image in ${{ steps.vars.outputs.container-name-tag }}; do
+            # Use --pull=never to ensure we are testing the just built image.
+            podman run --pull=never --rm -it $image /usr/bin/bash -x -c 'cd $HOME && printf '\''#include <iostream>\nint main(int argc, char **argv) { std::cout << "Hello\\n"; }'\'' | clang++ -x c++ - && ./a.out | grep Hello'
           done
 
   push-ci-container:

[boomanaiden154]

Why would it be trying to pull if the container exists locally?

The container shouldn't exist in the remote with the new tag.

Either way, seems like this fixes the issue, so approval for that.

[tstellar]

Why would it be trying to pull if the container exists locally?

The container shouldn't exist in the remote with the new tag.

Either way, seems like this fixes the issue, so approval for that.

You are correct that the --pull=never option is not strictly required, I just added it to be extra safe. Removing the testing for the :latest tag which was only available remotely is the part of the change the fixed my problem.

[boomanaiden154]

Ah. Keeping it on there for the extra assurance definitely doesn't hurt.