[mlir][shape] DCE unimplemented extra decl

[makslevental]

There are no implementations for these methods. This causes linker errors in certain build configurations.

[llvmbot]

@llvm/pr-subscribers-mlir-shape

Author: Maksim Levental (makslevental)

Changes

There are no implementations for these methods. This causes linker errors in certain build configurations.

---

Full diff: https://github.com/llvm/llvm-project/pull/121275.diff

1 Files Affected:

• (modified) mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td (-5)

diff --git a/mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td b/mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
index 08a0398e74b0cb..8bccba426ab12c 100644
--- a/mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
+++ b/mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
@@ -321,11 +321,6 @@ def Shape_DimOp : Shape_Op<"dim",
   let assemblyFormat = "$value `,` $index attr-dict `:` type($value) `,`"
                        "type($index) `->` type($extent)";
 
-  let builders = [
-    // Builder that allows passing a constant dimension as a simple integer.
-    OpBuilder<(ins "Value":$value, "int64_t":$index)>
-  ];
-
   let extraClassDeclaration = [{
     /// Get the `index` value as integer if it is constant.
     std::optional<int64_t> getConstantIndex();

[llvmbot]

@llvm/pr-subscribers-mlir

Author: Maksim Levental (makslevental)

Changes

There are no implementations for these methods. This causes linker errors in certain build configurations.

---

Full diff: https://github.com/llvm/llvm-project/pull/121275.diff

1 Files Affected:

• (modified) mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td (-5)

diff --git a/mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td b/mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
index 08a0398e74b0cb..8bccba426ab12c 100644
--- a/mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
+++ b/mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
@@ -321,11 +321,6 @@ def Shape_DimOp : Shape_Op<"dim",
   let assemblyFormat = "$value `,` $index attr-dict `:` type($value) `,`"
                        "type($index) `->` type($extent)";
 
-  let builders = [
-    // Builder that allows passing a constant dimension as a simple integer.
-    OpBuilder<(ins "Value":$value, "int64_t":$index)>
-  ];
-
   let extraClassDeclaration = [{
     /// Get the `index` value as integer if it is constant.
     std::optional<int64_t> getConstantIndex();

[jpienaar]

Good it's only one builder (it's a useful one and tiny, but seems it may have been missed when I split a commit and no one else needed it, probably as these are handled more automatically in a pass rather than being written by hand). Thanks for finding & fixing.