[AMDGPU][GISel] Fold 'min(min(x,y),z)' and 'max(max(x,y),z)' into min3 and max3 #124263
+1,073
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lialan
reviewed
Jan 24, 2025
Comment on lines
188
to
193
| def AMDGPURegBankCombiner | ||
| : GICombiner<"AMDGPURegBankCombinerImpl", | ||
| [unmerge_merge, unmerge_cst, unmerge_undef, zext_trunc_fold, | ||
| int_minmax_to_med3, ptr_add_immed_chain, fp_minmax_to_clamp, | ||
| fp_minmax_to_med3, fmed3_intrinsic_to_clamp, | ||
| minmax_to_minmax3, redundant_and]> {} |
There was a problem hiding this comment.
This lint is irrelevant, so probably we should exclude it from the PR.
lialan
reviewed
Jan 24, 2025
| def minmax_to_minmax3 | ||
| : GICombineRule< | ||
| (defs root:$min_or_max, minmax3_matchdata:$matchinfo), | ||
| (match(wip_match_opcode G_SMAX, G_SMIN, G_UMAX, G_UMIN, G_FMAXNUM, |
There was a problem hiding this comment.
See this: https://github.com/llvm/llvm-project/blob/main/llvm/docs/GlobalISel/MIRPatterns.rst#gallery
Can avoid using wip_match_opcode.
Ruhung
force-pushed
the
amdgpu_mixmax3
branch
from
c497398 to
15e8dc1
Compare
Ruhung
force-pushed
the
amdgpu_mixmax3
branch
from
15e8dc1 to
9e16747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR, test cases in progress.
Fold 'min(min(x,y),z)' and 'max(max(x,y),z)' into min3 and max3
Fixes: #123079