Skip to content

[mlir] Fix Wparentheses warning #146893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −8
Open

[mlir] Fix Wparentheses warning #146893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions mlir/lib/Dialect/Linalg/Transforms/PadTilingInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,8 @@ linalg::rewriteAsPaddedOp(RewriterBase &rewriter, TilingInterface opToPad,
// 2.a. Skip scalar-like operands.
Type operandType = operand.getType();
if (!isa<RankedTensorType>(operandType)) {
assert(!isa<ShapedType>(operandType) ||
isa<VectorType>(operandType) &&
"Unexpected non-vector ShapedType");
assert((!isa<ShapedType>(operandType) || isa<VectorType>(operandType)) &&
"Unexpected non-vector ShapedType");
newOperands.push_back(operand);
continue;
}
Expand Down
6 changes: 3 additions & 3 deletions mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1659,9 +1659,9 @@ createWriteOrMaskedWrite(OpBuilder &builder, Location loc, Value vecToStore,
}

// If missing, initialize the write indices to 0.
assert(writeIndices.empty() ||
writeIndices.size() == static_cast<size_t>(destRank) &&
"Invalid number of write indices!");
assert((writeIndices.empty() ||
writeIndices.size() == static_cast<size_t>(destRank)) &&
"Invalid number of write indices!");
if (writeIndices.empty()) {
auto zero = builder.create<arith::ConstantIndexOp>(loc, 0);
writeIndices.assign(destRank, zero);
Expand Down
4 changes: 2 additions & 2 deletions mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@ void CreateNdDescOp::build(OpBuilder &builder, OperationState &state,
shape.size() == strides.size() && shape.size() == offsets.size());

Type srcTy = source.getType();
assert(isa<IntegerType>(srcTy) ||
isa<MemRefType>(srcTy) && "Source has to be either int or memref.");
assert((isa<IntegerType, MemRefType>(srcTy)) &&
"Source has to be either int or memref.");

llvm::SmallVector<Value> dynamicOffsets;
llvm::SmallVector<Value> dynamicShape;
Expand Down
Loading