[NFC][clang] Rename clang/lib/CodeGen/TargetBuiltins/* files to avoid build warnings on macOS #149974
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… build warnings on macOS Signed-off-by: yronglin <[email protected]>
llvmbot
added
clang
|
@llvm/pr-subscribers-backend-directx @llvm/pr-subscribers-clang-codegen Author: None (yronglin) ChangesThis MR rename files in clang/lib/CodeGen/TargetBuiltins/* to avoid build warnings on macOS. Full diff: https://github.com/llvm/llvm-project/pull/149974.diff 12 Files Affected:
diff --git a/clang/lib/CodeGen/CMakeLists.txt b/clang/lib/CodeGen/CMakeLists.txt
index 0f2a352886e7f..e38c254709980 100644
--- a/clang/lib/CodeGen/CMakeLists.txt
+++ b/clang/lib/CodeGen/CMakeLists.txt
@@ -117,17 +117,17 @@ add_clang_library(clangCodeGen
PatternInit.cpp
SanitizerMetadata.cpp
SwiftCallingConv.cpp
- TargetBuiltins/ARM.cpp
- TargetBuiltins/AMDGPU.cpp
- TargetBuiltins/DirectX.cpp
- TargetBuiltins/Hexagon.cpp
- TargetBuiltins/NVPTX.cpp
- TargetBuiltins/PPC.cpp
- TargetBuiltins/RISCV.cpp
- TargetBuiltins/SPIR.cpp
- TargetBuiltins/SystemZ.cpp
- TargetBuiltins/WebAssembly.cpp
- TargetBuiltins/X86.cpp
+ TargetBuiltins/TargetBuiltinsARM.cpp
+ TargetBuiltins/TargetBuiltinsAMDGPU.cpp
+ TargetBuiltins/TargetBuiltinsDirectX.cpp
+ TargetBuiltins/TargetBuiltinsHexagon.cpp
+ TargetBuiltins/TargetBuiltinsNVPTX.cpp
+ TargetBuiltins/TargetBuiltinsPPC.cpp
+ TargetBuiltins/TargetBuiltinsRISCV.cpp
+ TargetBuiltins/TargetBuiltinsSPIR.cpp
+ TargetBuiltins/TargetBuiltinsSystemZ.cpp
+ TargetBuiltins/TargetBuiltinsWebAssembly.cpp
+ TargetBuiltins/TargetBuiltinsX86.cpp
TargetInfo.cpp
Targets/AArch64.cpp
Targets/AMDGPU.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/AMDGPU.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsAMDGPU.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/AMDGPU.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsAMDGPU.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/ARM.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsARM.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/ARM.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsARM.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/DirectX.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsDirectX.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/DirectX.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsDirectX.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/Hexagon.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsHexagon.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/Hexagon.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsHexagon.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/NVPTX.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsNVPTX.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/NVPTX.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsNVPTX.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/PPC.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsPPC.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/PPC.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsPPC.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/RISCV.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsRISCV.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/RISCV.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsRISCV.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/SPIR.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsSPIR.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/SPIR.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsSPIR.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/SystemZ.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsSystemZ.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/SystemZ.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsSystemZ.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/WebAssembly.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsWebAssembly.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/WebAssembly.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsWebAssembly.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/X86.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsX86.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/X86.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsX86.cpp
|
|
@llvm/pr-subscribers-backend-risc-v Author: None (yronglin) ChangesThis MR rename files in clang/lib/CodeGen/TargetBuiltins/* to avoid build warnings on macOS. Full diff: https://github.com/llvm/llvm-project/pull/149974.diff 12 Files Affected:
diff --git a/clang/lib/CodeGen/CMakeLists.txt b/clang/lib/CodeGen/CMakeLists.txt
index 0f2a352886e7f..e38c254709980 100644
--- a/clang/lib/CodeGen/CMakeLists.txt
+++ b/clang/lib/CodeGen/CMakeLists.txt
@@ -117,17 +117,17 @@ add_clang_library(clangCodeGen
PatternInit.cpp
SanitizerMetadata.cpp
SwiftCallingConv.cpp
- TargetBuiltins/ARM.cpp
- TargetBuiltins/AMDGPU.cpp
- TargetBuiltins/DirectX.cpp
- TargetBuiltins/Hexagon.cpp
- TargetBuiltins/NVPTX.cpp
- TargetBuiltins/PPC.cpp
- TargetBuiltins/RISCV.cpp
- TargetBuiltins/SPIR.cpp
- TargetBuiltins/SystemZ.cpp
- TargetBuiltins/WebAssembly.cpp
- TargetBuiltins/X86.cpp
+ TargetBuiltins/TargetBuiltinsARM.cpp
+ TargetBuiltins/TargetBuiltinsAMDGPU.cpp
+ TargetBuiltins/TargetBuiltinsDirectX.cpp
+ TargetBuiltins/TargetBuiltinsHexagon.cpp
+ TargetBuiltins/TargetBuiltinsNVPTX.cpp
+ TargetBuiltins/TargetBuiltinsPPC.cpp
+ TargetBuiltins/TargetBuiltinsRISCV.cpp
+ TargetBuiltins/TargetBuiltinsSPIR.cpp
+ TargetBuiltins/TargetBuiltinsSystemZ.cpp
+ TargetBuiltins/TargetBuiltinsWebAssembly.cpp
+ TargetBuiltins/TargetBuiltinsX86.cpp
TargetInfo.cpp
Targets/AArch64.cpp
Targets/AMDGPU.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/AMDGPU.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsAMDGPU.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/AMDGPU.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsAMDGPU.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/ARM.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsARM.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/ARM.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsARM.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/DirectX.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsDirectX.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/DirectX.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsDirectX.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/Hexagon.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsHexagon.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/Hexagon.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsHexagon.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/NVPTX.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsNVPTX.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/NVPTX.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsNVPTX.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/PPC.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsPPC.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/PPC.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsPPC.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/RISCV.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsRISCV.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/RISCV.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsRISCV.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/SPIR.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsSPIR.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/SPIR.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsSPIR.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/SystemZ.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsSystemZ.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/SystemZ.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsSystemZ.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/WebAssembly.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsWebAssembly.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/WebAssembly.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsWebAssembly.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/X86.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsX86.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/X86.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsX86.cpp
|
|
@llvm/pr-subscribers-backend-amdgpu Author: None (yronglin) ChangesThis MR rename files in clang/lib/CodeGen/TargetBuiltins/* to avoid build warnings on macOS. Full diff: https://github.com/llvm/llvm-project/pull/149974.diff 12 Files Affected:
diff --git a/clang/lib/CodeGen/CMakeLists.txt b/clang/lib/CodeGen/CMakeLists.txt
index 0f2a352886e7f..e38c254709980 100644
--- a/clang/lib/CodeGen/CMakeLists.txt
+++ b/clang/lib/CodeGen/CMakeLists.txt
@@ -117,17 +117,17 @@ add_clang_library(clangCodeGen
PatternInit.cpp
SanitizerMetadata.cpp
SwiftCallingConv.cpp
- TargetBuiltins/ARM.cpp
- TargetBuiltins/AMDGPU.cpp
- TargetBuiltins/DirectX.cpp
- TargetBuiltins/Hexagon.cpp
- TargetBuiltins/NVPTX.cpp
- TargetBuiltins/PPC.cpp
- TargetBuiltins/RISCV.cpp
- TargetBuiltins/SPIR.cpp
- TargetBuiltins/SystemZ.cpp
- TargetBuiltins/WebAssembly.cpp
- TargetBuiltins/X86.cpp
+ TargetBuiltins/TargetBuiltinsARM.cpp
+ TargetBuiltins/TargetBuiltinsAMDGPU.cpp
+ TargetBuiltins/TargetBuiltinsDirectX.cpp
+ TargetBuiltins/TargetBuiltinsHexagon.cpp
+ TargetBuiltins/TargetBuiltinsNVPTX.cpp
+ TargetBuiltins/TargetBuiltinsPPC.cpp
+ TargetBuiltins/TargetBuiltinsRISCV.cpp
+ TargetBuiltins/TargetBuiltinsSPIR.cpp
+ TargetBuiltins/TargetBuiltinsSystemZ.cpp
+ TargetBuiltins/TargetBuiltinsWebAssembly.cpp
+ TargetBuiltins/TargetBuiltinsX86.cpp
TargetInfo.cpp
Targets/AArch64.cpp
Targets/AMDGPU.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/AMDGPU.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsAMDGPU.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/AMDGPU.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsAMDGPU.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/ARM.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsARM.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/ARM.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsARM.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/DirectX.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsDirectX.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/DirectX.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsDirectX.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/Hexagon.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsHexagon.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/Hexagon.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsHexagon.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/NVPTX.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsNVPTX.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/NVPTX.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsNVPTX.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/PPC.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsPPC.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/PPC.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsPPC.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/RISCV.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsRISCV.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/RISCV.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsRISCV.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/SPIR.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsSPIR.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/SPIR.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsSPIR.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/SystemZ.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsSystemZ.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/SystemZ.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsSystemZ.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/WebAssembly.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsWebAssembly.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/WebAssembly.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsWebAssembly.cpp
diff --git a/clang/lib/CodeGen/TargetBuiltins/X86.cpp b/clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsX86.cpp
similarity index 100%
rename from clang/lib/CodeGen/TargetBuiltins/X86.cpp
rename to clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsX86.cpp
|
You can test this locally with the following command:git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef[^a-zA-Z0-9_-]|UndefValue::get)' 'HEAD~1' HEAD clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsAMDGPU.cpp clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsARM.cpp clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsDirectX.cpp clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsHexagon.cpp clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsNVPTX.cpp clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsPPC.cpp clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsRISCV.cpp clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsSPIR.cpp clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsSystemZ.cpp clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsWebAssembly.cpp clang/lib/CodeGen/TargetBuiltins/TargetBuiltinsX86.cppThe following files introduce new uses of undef:
Undef is now deprecated and should only be used in the rare cases where no replacement is possible. For example, a load of uninitialized memory yields In tests, avoid using For example, this is considered a bad practice: define void @fn() {
...
br i1 undef, ...
}Please use the following instead: define void @fn(i1 %cond) {
...
br i1 %cond, ...
}Please refer to the Undefined Behavior Manual for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR rename files in clang/lib/CodeGen/TargetBuiltins/* to avoid build warnings on macOS.
https://discourse.llvm.org/t/rfc-rename-source-files-in-clang-lib-codegen-targetbuiltins/87462