-
Notifications
You must be signed in to change notification settings - Fork 353
[FMV][AArch64] Fix missing FMV defines for AArch64 in LNT Makefile #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add conditional CFLAGS definitions for AArch64 targets to support FMV-related behavior on Darwin and Linux platforms. - Adds -DHAS_DARWIN_FMV when ARCH=AArch64 and TARGET_OS=Darwin - Adds -DHAS_LINUX_FMV when ARCH=AArch64 and TARGET_OS=Linux This change fixes build errors when running LNT tests on AArch64 systems with platform-specific FMV handling.
I am a bit puzzled with the equivalent cmake code
The way I read it |
@labrinea Thank you for your comment. I've confirmed how However, when I run LNT with a Makefile that includes my modifications, the build and execution complete without any issues. In other words, even though |
- Adds a pre-build check in the Makefile for the __init_cpu_features_resolver, __init_cpu_features symbol. - The result is used to define CHECK_FMV (HAS_DARWIN_FMV, HAS_LINUX_FMV), which conditionally compiles the platform-specific code in aarch64-init-cpu-features.c
@labrinea
To match the
TestingIn my local environment, the check for the Could you please test these changes in an environment where the |
I have raised #270 to address the problem. I am not sure who to ask for review. I tested it and works on a system that has the |
Hi @labrinea , Thank you for the review and for following up with a fix. I noticed that instead of merging PR #269, you made a separate commit to address the issue. If there are specific improvements or changes needed, I’d sincerely appreciate your guidance so that I can apply them myself. Thanks again for your time and help! |
Hi @IamYJLee. Apologies for not guiding you how to improve this PR instead. Since I spent the time investing this issue from my end I thought it's easier to raise a new PR with my changes. Allow me to explain why this patch doesn't work.
Feel free to adjust this PR accordingly and credit @momchil-velikov for helping me on this on the commit message. There are still two issues with my patch that need to be addressed, so we need someone to review these first. |
@labrinea I completely understand your rationale for submitting a new PR, and I appreciate the clarity you've provided regarding the behavior of With your permission, I would like to continue the work from here and revise the patch to address the remaining issues you mentioned. I will ensure that appropriate credit is given to you in the commit message for your valuable contributions. Please let me know if you have any objections. Otherwise, I’ll proceed with the necessary updates. |
Add conditional CFLAGS definitions for AArch64 targets to support FMV-related behavior on Darwin and Linux platforms.
This change fixes build errors when running LNT tests on AArch64 systems with platform-specific FMV handling.
This patch reflects the changes from llvm/llvm-test-suite@d24d5dcd.
ERROR CONTEXT
Before this patch, LNT test runs on AArch64 platforms (e.g., macOS arm64) could fail with missing symbol errors: