[ClangBuilder] Pass -k to make for test-suite runs #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When llvm/llvm-lnt@7688741 enabled using Ninja, it removed the -k flag from make. -k causes make to carry on if there's a build failure. Without this flag, a single compilation failure turns into thousands of missing executables in the final results. As subsequent targets are not built. llvm/llvm-lnt#25 is adding an option to the lnt runner to pass options to the build tool. This PR uses that to pass -k to make to restore the old behaviour on the build bots.
|
ping! |
omjavaid
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When llvm/llvm-lnt@7688741 enabled using Ninja, it removed the -k flag from make. -k causes make to carry on if there's a build failure.
Without this flag, a single compilation failure turns into thousands of missing executables in the final results. As subsequent targets are not built.
llvm/llvm-lnt#25 is adding an option to the lnt runner to pass options to the build tool.
This PR uses that to pass -k to make to restore the old behaviour on the build bots.