[CI] Add namespace names as parameters to premerge_resources #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
boomanaiden154
added a commit
to boomanaiden154/llvm-zorg
that referenced
this pull request
Jul 18, 2025
This enables a bit of simplification as we can remove some strings where they really should be variables. This will also help in a future patch where we also need to access the namespace name inside the gke_cluster module as it will enable having a common definition to ensure that they do not differ. Pull Request: llvm#507
boomanaiden154
added a commit
to boomanaiden154/llvm-zorg
that referenced
this pull request
Jul 18, 2025
This enables a bit of simplification as we can remove some strings where they really should be variables. This will also help in a future patch where we also need to access the namespace name inside the gke_cluster module as it will enable having a common definition to ensure that they do not differ. Pull Request: llvm#507
Created using spr 1.3.4 [skip ci]
boomanaiden154
requested review from
dschuff,
lnihlen,
gburgessiv,
Keenuts and
cmtice
cmtice
reviewed
Jul 18, 2025
cmtice
reviewed
Jul 18, 2025
cmtice
reviewed
Jul 18, 2025
cmtice
approved these changes
Jul 18, 2025
Created using spr 1.3.4 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/llvm-zorg
that referenced
this pull request
Jul 20, 2025
This enables a bit of simplification as we can remove some strings where they really should be variables. This will also help in a future patch where we also need to access the namespace name inside the gke_cluster module as it will enable having a common definition to ensure that they do not differ. Pull Request: llvm#507
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/llvm-zorg
that referenced
this pull request
Jul 20, 2025
This enables a bit of simplification as we can remove some strings where they really should be variables. This will also help in a future patch where we also need to access the namespace name inside the gke_cluster module as it will enable having a common definition to ensure that they do not differ. Pull Request: llvm#507
boomanaiden154
changed the base branch from
users/boomanaiden154/main.ci-add-namespace-names-as-parameters-to-premerge_resources
to
main
boomanaiden154
deleted the
users/boomanaiden154/ci-add-namespace-names-as-parameters-to-premerge_resources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables a bit of simplification as we can remove some strings where they
really should be variables. This will also help in a future patch where we also
need to access the namespace name inside the gke_cluster module as it will
enable having a common definition to ensure that they do not differ.