Add reflect tests
#287
Add reflect tests
#287
Conversation
test/Feature/HLSLLib/reflect.16.test
Outdated
| StructuredBuffer<half4> IncidentRay : register(t0); | ||
| StructuredBuffer<half4> Wall1 : register(t1); | ||
| StructuredBuffer<half4> Wall2 : register(t2); | ||
| StructuredBuffer<half4> Wall3 : register(t3); |
There was a problem hiding this comment.
You're using StructuredBuffers, which means you can define everything you need in one buffer for simplicity, right? Same with the output buffer.
There was a problem hiding this comment.
I think you're right, but I personally find it more readable / maintainable to separate things out.
Won't need to worry as much about padding / alignment this way.
test/Feature/HLSLLib/reflect.16.test
Outdated
| - Name: Wall1 | ||
| Format: Float16 | ||
| Stride: 8 | ||
| Data: [ 0xbc00, 0x0000, 0x0000, 0x0000 ] |
There was a problem hiding this comment.
Why are most of the components for all of the inputs zeros? Axis aligned edge cases are probably the least interesting. A few random number inputs in a reasonable range should be sufficient to test the math expansion, and would be better than leaving z and w dimensions zeroed for all inputs (in my opinion).
test/Feature/HLSLLib/reflect.32.test
Outdated
| - Name: Wall1 | ||
| Format: Float32 | ||
| Stride: 16 | ||
| Data: [ -1.0, 0.0, 0.0, 0.0 ] |
There was a problem hiding this comment.
Using 1.0 and so many zero components means this is only testing a degenerate edge case. I really think we should be testing with combinations of numbers in reasonable ranges and using a ULP tolerance at least as high as the potential variance in expansions and operation precisions.
Icohedron
dismissed
their stale review
As tex suggested, this PR could include some more varied tests to exercise the function under more interesting scenarios.
| - Name: ExpectedResult4D | ||
| Format: Float16 | ||
| Stride: 8 | ||
| Data: [ 0x3400, 0xb800, 0x3800, 0xba00, 0x3400, 0xb800, 0x3800, 0xba00 ] |
There was a problem hiding this comment.
nit: Can we annotate what the decimal values are for these (and elsewhere)
| // 4D case | ||
| half4 result4D = reflect(IncidentRay4D[0].xyzw, normalize(Wall4D[0].xyzw)); | ||
| Result4D[0] = result4D; | ||
| half4 result4D_constant = reflect(half4(0.5, -0.25, 0.75, -0.5), half4(0.5, 0.5, 0.5, 0.5)); |
There was a problem hiding this comment.
I believe all the values that are used in this test (and all others) are exactly representable in IEE 754. Should we have an extra test that uses values that will be rounded?
There was a problem hiding this comment.
0.70710677 gets rounded to 0.70703125 in the 3D test. Does that resolve your concern?
This PR adds tests for the
reflectfunction. Adds float16 and float32 test files.Fixes #170