Update docs and .env file to reflect PYTHONPATH variability #4332
+48
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update scripts and readme docs to grab PYTHONPATH from env file. Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
marbre
requested changes
Oct 6, 2025
Signed-off-by: zjgarvey <[email protected]>
…-tree dir. Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
This reverts commit 54a63f8.
This reverts commit 09de7e5.
This reverts commit 3c9a1f8.
This reverts commit 6978352.
This reverts commit 493696f.
This reverts commit 8fde78e.
zjgarvey
changed the title
.env file directly during cmake build…ix_cmake_python_issues
marbre
approved these changes
Oct 9, 2025
Comment on lines
+26
to
+30
| if [[ "${in_tree_pkg_dir}" -nt "${out_of_tree_pkg_dir}" ]]; then | ||
| python_packages_dir="${in_tree_pkg_dir}" | ||
| else | ||
| python_packages_dir="${out_of_tree_pkg_dir}" | ||
| fi |
There was a problem hiding this comment.
I am not sure if that logic is desired here or if it should be an external argument?
There was a problem hiding this comment.
Whether the build was in-tree/out-of-tree?
Yeah, we could make it take a command line arg and error out if the dir is missing, but just checking both seems fine to me, and aligns with the other two scripts that need to set a PYTHONPATH.
sahas3
reviewed
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the docs and
build_tools/write_env_file.shto correctly identify thePYTHONPATHbased on in-tree vs. out-of-tree builds.Additionally, I've updated various build configure commands to include a directive to align
PythonwithPython3, since having conflicting versions of python can cause issues when not explicitly setting both to the same python executable.Resolves #4331