Fix static shape propagation in aten.as_strided
#4334
+17
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intermediate view operations were not properly propagating static shapes. Thanks to Zach for pointing out how to fix this issue, see #4325 for more discussion. They key change is
viewShapeInts[dim] = size
to preserve the static shape.I have kept the e2e Python tests for
aten.unflatten
and the MLIR tests for the TorchToLinalg conversion ofunflatten
as well, I think they may be useful for some more coverage that wasn't there before, but open to suggestions on whether or not to keep these.