Skip to content

Conversation

raayandhar
Copy link

Intermediate view operations were not properly propagating static shapes. Thanks to Zach for pointing out how to fix this issue, see #4325 for more discussion. They key change is viewShapeInts[dim] = size to preserve the static shape.

I have kept the e2e Python tests for aten.unflatten and the MLIR tests for the TorchToLinalg conversion of unflatten as well, I think they may be useful for some more coverage that wasn't there before, but open to suggestions on whether or not to keep these.

Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I'd remove the unrelated tests (unflatten isn't actually related to the code change). Let me know when you'd like me to take another look and we can get it merged.

@raayandhar
Copy link
Author

Thanks for the fix. I'd remove the unrelated tests (unflatten isn't actually related to the code change). Let me know when you'd like me to take another look and we can get it merged.

Thanks for the feedback - I think it should be good for a look now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants