Remove loading of Copilot Arena tab when env variable is not set #3645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infwinston
reviewed
Dec 19, 2024
fastchat/serve/monitor/monitor.py
Outdated
Comment on lines
1037
to
1051
| try: | ||
| with gr.Tab("Copilot Arena Leaderboard", id=5): | ||
| from fastchat.serve.monitor.copilot_arena import ( | ||
| build_copilot_arena_tab, | ||
| ) | ||
| from fastchat.serve.monitor.copilot_arena import ( | ||
| build_copilot_arena_tab, | ||
| copilot_arena_leaderboard_url, | ||
| ) | ||
|
|
||
| if not copilot_arena_leaderboard_url: | ||
| raise ValueError( | ||
| "COPILOT_ARENA_LEADERBOARD_URL environment variable is not set. " | ||
| "Please configure it to a valid URL." | ||
| ) | ||
| with gr.Tab("Copilot Arena Leaderboard", id=5): | ||
| build_copilot_arena_tab() | ||
| except Exception as e: | ||
| print(f"Unable to build Copilot Arena's Leaderboard. Error: {e}") |
There was a problem hiding this comment.
do you think we should do try catch or just if else like below
if copilot_arena_leaderboard_url:
with gr.Tab("Copilot Arena Leaderboard", id=5):
build_copilot_arena_tab()
else:
print(f"Unable to build Copilot Arena's Leaderboard")
There was a problem hiding this comment.
Yes! I've just updated this
infwinston
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adding a small change to #3618, which doesn't load the Copilot Arena leaderboard tab when the environment variable is not set.
Related issue number (if applicable)
Checks
format.shto lint the changes in this PR.