Feat: Require comparisons to be strict #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OndraM
requested review from
jirinovak,
D0L1K,
kdosiodjinud,
MortalFlesh,
hokypierce and
MarketaSebkova
D0L1K
approved these changes
Apr 26, 2024
hokypierce
approved these changes
Apr 29, 2024
jirinovak
approved these changes
Apr 30, 2024
OndraM
force-pushed
the
feature/strict-comparisons
branch
from
4a35771
to
5ca8737
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://cs.symfony.com/doc/rules/strict/strict_comparison.html
Loose comparisons using
!=and==are disallowed.