Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for V3: Graphene, Flask GraphQL, Django GraphQL #61

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

leahein
Copy link

@leahein leahein commented Apr 30, 2021

Now that graphene and graphene-django have released a beta of v3, and flask-graphql is being moved to graphql-server, this update (which would likely be a beta release as well) supports those versions.

The changes include:

  • Updating dependencies
  • Moving from flask-graphql to graphql-server[flask]
  • Dropping support for Python versions < 3.6 (since the underlying dependencies dropped support)
  • Updates to get all tests passing (related changes)
  • Update README

Happy to make any additional changes, etc. to get this released 🚀

@leahein
Copy link
Author

leahein commented May 27, 2021

I dropped support and removed testing / CI for older versions of Python / pypy, since those versions are no longer supported by graphql-server.

@leahein
Copy link
Author

leahein commented Jun 22, 2021

Is there something blocking this from being released?

@lmcgartland
Copy link
Owner

Hi @leahein I will take a look--I think the best course of action would be to track alongside the graphene-django beta releases and issue a 3.0 release when that has been finalized. Thank you for taking the initiative to ensure compatibility!

@lmcgartland lmcgartland self-assigned this Jun 24, 2021
@wangsha
Copy link

wangsha commented Nov 25, 2021

looking forward to have this issue merged. latest setup will endup with this error. graphql-python/flask-graphql#87

@leahein
Copy link
Author

leahein commented Nov 26, 2021

latest setup will endup with this error. graphql-python/flask-graphql#87

This PR migrates from flask-graphql to graphql-server, which should resolve that issue.

@HarrisonAlmeida
Copy link

Hey @lmcgartland any input on this being merged anytime soon?

@Toruitas
Copy link

Toruitas commented Jun 24, 2022

Looking forward to this merge. Last piece blocking moving my stack from GraphQL 2 to 3.

Edit: Now that it would appear Graphene-Django is a dead project, that might put this project in flux as well. graphql-python/graphene-django#1324
Edit 2: It's not dead anymore!

@felixmeziere
Copy link

It's not dead anymore! Can we merge this?

@JackGoldsworth
Copy link

Any update on this?

@coler-j
Copy link

coler-j commented Jun 13, 2023

@leahein @lmcgartland any way to get this one in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to graphql-core v3
8 participants