Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typer 0.14.0+ incompatibility #98

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Conversation

ncoghlan
Copy link
Collaborator

@ncoghlan ncoghlan commented Dec 5, 2024

Also prepares for 0.2.1 bugfix release.

Closes #96

Also prepares for 0.2.1 bugfix release.

Closes #96
@ncoghlan
Copy link
Collaborator Author

ncoghlan commented Dec 5, 2024

Turns out the way I had implemented this was not the intended way to do it (not sure how I missed trying the actual right way when adding the app level callback)

Copy link

github-actions bot commented Dec 5, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-05 06:11 UTC

@ncoghlan
Copy link
Collaborator Author

ncoghlan commented Dec 5, 2024

Also including a dependency update to ensure compatibility with the latest Typer release (the original problem reported in #96), as well as release process cleanups that came up when preparing 0.2.1.

@ncoghlan ncoghlan changed the title Fix Typer 0.12.5+ incompatibility Fix Typer 0.14.0+ incompatibility Dec 5, 2024
@ncoghlan
Copy link
Collaborator Author

ncoghlan commented Dec 5, 2024

The incompatibility was actually with 0.14.0+, not 0.12.5+ (0.12.5 was the previously pinned-and-working-version).

I'll fix that in the change log before tagging the release (no reason to trigger a full CI run just for that).

@ncoghlan ncoghlan merged commit ddd5780 into main Dec 5, 2024
11 checks passed
@ncoghlan ncoghlan deleted the fix-typer-name-callback-issue branch December 5, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Installation not working due to typer mismatch
1 participant