Fix peer connect race #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orbitalturtle
force-pushed
the
fix-peer-connect-race
branch
from
bee48bf
to
3cb55df
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #121 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 1 1
Lines 97 97
======================================
Misses 97 97 ☔ View full report in Codecov by Sentry. |
orbitalturtle
force-pushed
the
fix-peer-connect-race
branch
from
c9746ba
to
ae78327
Compare
|
Looks like the cltv expiry change breaks our itests. But that might be because our fork of ldk-sample, which we use for the integration tests, is woefully behind EDIT: I confirmed this is because our fork of ldk-sample is behind. I'm removing the CLTV expiry commit and moving it to the transient-keys branch instead. Once #119 is in, we can merge that bug fix as well. |
orbitalturtle
force-pushed
the
fix-peer-connect-race
branch
from
ae78327
to
cee215c
Compare
orbitalturtle
force-pushed
the
fix-peer-connect-race
branch
from
cee215c
to
aa9caf9
Compare
This was referenced Jul 3, 2024
If we need to connect directly to the introduction node provided by an offer, LNDK's onion messenger will receive a PeerConnected event to process this new connection. When we first look at that new peer, the features map is empty, and LNDK decides onion support must be "false". This botches future payment attempts, because the onion messenger thinks that this peer doesn't support onion messaging, and shouldn't be considered in future payment paths. To fix this, we add a little wait loop that looks for a non-empty map.
orbitalturtle
force-pushed
the
fix-peer-connect-race
branch
from
aa9caf9
to
3eeb40f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles an issue that has popped up in bolt12-playground when paying Eclair offers.
If we need to connect directly to the introduction node, LNDK's onion messenger receives a PeerConnected event to process this new connection. When we first look at that new peer, the features map is empty, and LNDK decides onion support must be "false". This messes up future payment attempts, because the onion messenger thinks that this peer doesn't support onion messaging, and shouldn't be considered in future payment paths. To fix this, the first commit adds a little wait loop that looks for a non-empty map.