Server: Config defaults to root and Datadir #193
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LNDK is already using a datadir to store TLS certificates. In this PR we expect lndk.conf file to be either in root of the project or the data_dir as defaults. Precedence is root > data_dir.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 1 1
Lines 126 136 +10
======================================
- Misses 126 136 +10 ☔ View full report in Codecov by Sentry. |
|
Thanks. I'll have a closer look this weekend. Catching up. |
|
I'm happy to have this PR be the "follow-up" to #192 as discussed in #192 (comment) 😄. Would you be okay to broaden the scope a bit as I imagine there's a dependency there anyway? |
|
@dunxen sure, i'll take it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #183
Changed my mind on this, we might wanna think a bit broader on these config files and
data_diras stated in this comment.Drafting for now
In this PR
Similar to bitcoin
~/.bitcoin/bitcoin.confand~/.lnd/lnd.conf, we add data_dir as default path to store conf file.Added some prevalence root project conf.file wouldn't be overriden by datadir conf file.
How can i test it?
Add some files with different configurations:
lndk.confin root project~/.lndk/lndk.confin datadirTest which configurations are used. Easy way to do it is to point to different lnd servers and point
addressin each file to each of them.Why this?
Standardness and ease when deploying