Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging fixes #96

Merged
merged 2 commits into from
Mar 16, 2024
Merged

Logging fixes #96

merged 2 commits into from
Mar 16, 2024

Conversation

orbitalturtle
Copy link
Collaborator

While debugging, I ran into a couple of logging things that could be improved a bit.

@orbitalturtle orbitalturtle changed the base branch from master to cli-pay-offer March 15, 2024 05:19
Copy link
Collaborator

@carlaKC carlaKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - just one comment

src/main.rs Outdated
@@ -25,6 +27,16 @@ async fn main() -> Result<(), ()> {
.0;

let lnd_args = LndCfg::new(config.address, config.cert, config.macaroon);
let log_level = match config.log_level {
Some(level) => LevelFilter::from_str(&level).unwrap_or_else(|_| {
panic!(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error out vs panic?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, better to keep it consistent.

@carlaKC carlaKC merged commit 088272e into cli-pay-offer Mar 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants