plugin/transport: Prototype QUIC transport

[coufalja]

Prototype UDP based transport #90

[lni]

@coufalja thanks for the PR. a few issues and questions -

1. in quicTransport.openStreamTo(), tls.Config.InsecureSkipVerify is always set to true. Any particular reason to do this?

2. please add the copyright notice to each source file. the default copyright notice is provided below

// Copyright 2017-2021 Lei Ni ([email protected]) and other contributors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//     http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

3. please add some tests for this quic transport module, say in plugin/plugin_test.go.

4. please add some comments to the factory.go to indicate that this transport module is experimental for now. such notice can be reviewed & removed later.

[coufalja]

Thank you for a QUICk review, I am going to add tests soon. I've covered the other stuff already.

[lni]

@coufalja thanks for the update. A couple more quick questions -

1. the CRC code has been removed, when TLS is not enabled, how data integrality is checked?

2. for quicTransport.Start(), my understanding is that listener is like a server instance, listener.Accept() running inside a loop handles incoming connections from different clients, each of such connection is represented by a session instance s and s.AcceptStream() running inside its own loop is to keep getting byte streams sent by the client, but why there is another loop inside serveStream()? That is let's say if I have one client connected to the server and two pb.MessageBatch are sent to the server by the client on that connection, will the server side return two different stream instances and I get can get one pb.MessageBatch from each of those two stream instances or there will be only one stream instances with two pb.MessageBatch both can be read from it?

[coufalja]

1. the CRC code has been removed, when TLS is not enabled, how data integrality is checked?

The QUIC cannot be used without TLS, I have added an error return if you try to instantiate QUIC transport without TLS configured.

2. for quicTransport.Start(), my understanding is that listener is like a server instance, listener.Accept() running inside a loop handles incoming connections from different clients, each of such connection is represented by a session instance s and s.AcceptStream() running inside its own loop is to keep getting byte streams sent by the client, but why there is another loop inside serveStream()? That is let's say if I have one client connected to the server and two pb.MessageBatch are sent to the server by the client on that connection, will the server side return two different stream instances and I get can get one pb.MessageBatch from each of those two stream instances or there will be only one stream instances with two pb.MessageBatch both can be read from it?

You are absolutely right 🤦 in it being wrong, I will fix it.

[lni]

@coufalja thanks for the input. I will update NodeHost to print out a warning message if NodeHost is created without TLS.

internal/transport/tests contains some keys & certificates that can be used in tests, please feel free to use them when adding tests to the quic plugin.

[lni]

@coufalja are you adding more tests? I can a see an added test covering the creation and shutdown of the quic transport module, some tests to check that the transport module actual works will be useful. thanks!

[vtolstov]

any chance to get this completed and merged?