sdb: support any fs.depth starting values. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavosr8
approved these changes
Nov 14, 2024
Unlike the {E,P}BPM and FOFB SDB filesystems, which start at fs.depth=1,
the Timing SDB filesystem has a single item, at fs.depth=0. Instead of
hardcoding anything specific, we can simply support any starting depth.
Without this change, printing Timing SDB information hits the
indentation assertion, due to underflow when subtracting 1 from 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the {E,P}BPM and FOFB SDB filesystems, which start at fs.depth=1, the Timing SDB filesystem has a single item, at fs.depth=0. Instead of hardcoding anything specific, we can simply support any starting depth.
Without this change, printing Timing SDB information hit the indentation assertion, due to underflow when subtracting 1 from 0.
@henriquesimoes
@gustavosr8