This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Fix filtering_lines parameter to also apply when inline_mode is false
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix some minor style inconsistencies - Update to Ruby 3
barbosa
approved these changes
Apr 19, 2022
|
That should be fine. Thank you for your contribution, @petitJAM. Appreciate it. |
|
@barbosa Not to be annoying or rush you or anything, but when would you expect to publish a new version of the gem? I'd like to set myself a reminder to update our system to the official release since I'm installing from my branch currently. |
|
just published it @ https://rubygems.org/gems/danger-android_lint/versions/0.0.10 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with #30 / #18
I upgraded to Ruby 3 since I couldn't get 2.3.5 to install on my machine (I didn't try very hard 😅). I'm not noticing any problems, so I think it's good.