Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prior PR, plus exception declarations #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

barrychapman
Copy link

Added exception declarations to the PHP Doc blocks.

config(), dirty(), session() and name() were corrected to use new methods.
Added declarations of exceptions thrown in PHPDoc blocks.
@barrychapman
Copy link
Author

Not entirely sure why the travis build is failing, it appears to be a configuration issue?

@beporter
Copy link
Contributor

This is the first time this project has run a Travis build in good long while. I'm sure something's out of date.

@barrychapman
Copy link
Author

Gonna try resubmitting request.. not sure why it failed there. Seems to be a conf issue with oauth

  [RuntimeException]                       
  github-oauth.github.com is not defined.  ```

@barrychapman
Copy link
Author

The problem is this:
composer config -g github-oauth.github.com $GITHUB_TOKEN

That variable is either blank, or something else. Since GH said there are no conflicts, can you merge this? I use this on a lot of projects :) And I don't want to go thru the mess of forking it!

@barrychapman
Copy link
Author

@beporter see this issue:

crysalead/chaos-orm#1

@beporter
Copy link
Contributor

Unfortunately I’m not a maintainer on the project anymore, so I don’t have the ability to merge (or to fix the Travis env var.) I think the best I can do to help is ping @ricog and @kriskd to see if maybe they can assist here.

@barrychapman
Copy link
Author

@ricog @kriskd can you guys assist?

@barrychapman
Copy link
Author

@justinyost can you assist here?

@justinyost
Copy link
Contributor

@barrychapman looks like @kriskd just merged the fix for the github tokens for Travis.

@kriskd
Copy link
Member

kriskd commented Aug 14, 2018

@barrychapman If you can rebase your work and fix that conflict, I can get your PR approved and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants