-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prior PR, plus exception declarations #20
base: master
Are you sure you want to change the base?
Conversation
config(), dirty(), session() and name() were corrected to use new methods.
Added declarations of exceptions thrown in PHPDoc blocks.
Not entirely sure why the travis build is failing, it appears to be a configuration issue? |
This is the first time this project has run a Travis build in good long while. I'm sure something's out of date. |
Gonna try resubmitting request.. not sure why it failed there. Seems to be a conf issue with oauth
|
The problem is this: That variable is either blank, or something else. Since GH said there are no conflicts, can you merge this? I use this on a lot of projects :) And I don't want to go thru the mess of forking it! |
@beporter see this issue: |
@justinyost can you assist here? |
@barrychapman looks like @kriskd just merged the fix for the github tokens for Travis. |
@barrychapman If you can rebase your work and fix that conflict, I can get your PR approved and merged. |
Added exception declarations to the PHP Doc blocks.