Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cockroach copy target #2070

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

Cockroach copy target #2070

wants to merge 41 commits into from

Conversation

Shiverwarp
Copy link
Contributor

Just trying to block out the structure a bit in this draft

@Shiverwarp Shiverwarp marked this pull request as draft September 6, 2024 12:13
packages/garbo/src/tasks/cockroachPrep.ts Outdated Show resolved Hide resolved
packages/garbo/src/index.ts Outdated Show resolved Hide resolved
packages/garbo/src/index.ts Outdated Show resolved Hide resolved
packages/garbo/src/index.ts Outdated Show resolved Hide resolved
* Push some improvements and fixes to make this more accessible.

* Update packages/garbo/src/tasks/cockroachPrep.ts

Co-authored-by: neil <[email protected]>

* Fix the overcapstat element

* Add bonuses for fun equipment and carnplant

* Do effect removal first, shruggable first

* Genericize our debuff picker

* Add some breaks

* Fix the debuff item logic and other small things

* Use the pref for clipper unlocked rather than the proxy of storm runs

* Move final cockroach fight to later to benefit from buffs

* Update packages/garbo/src/index.ts

Co-authored-by: neil <[email protected]>

* Filter debuff items down to potions

* Optimize Giant Giant crab, further limit debuff scope to buyable or have()

* 100 stat is fine; > 100 isn't

* Avoid certain debuff items

* fix the avoid bad debuff function, add avoid candelabara

* refactor

---------

Co-authored-by: neil <[email protected]>
Co-authored-by: horrible little slime <[email protected]>
@Ignose
Copy link
Contributor

Ignose commented Jan 16, 2025

What else does this need to move to live? Anything we're waiting on?

@Shiverwarp
Copy link
Contributor Author

Shiverwarp commented Jan 16, 2025

What else does this need to move to live? Anything we're waiting on?

We can just check here to see which comments/reviews are still active: https://github.com/loathers/garbage-collector/pull/2070/files

Also, I'm unsure about having two Choose Trash Island tasks in the separate quests, how does that affect things?

@Ignose
Copy link
Contributor

Ignose commented Jan 16, 2025

Works great! Been running it for two? Three? months that way

@spaghetti-squash spaghetti-squash marked this pull request as ready for review January 23, 2025 21:08
packages/garbo/src/tasks/cockroachPrep.ts Outdated Show resolved Hide resolved
packages/garbo/src/tasks/cockroachPrep.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants