moving help above mallprices & main.php check #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reading through this I can see why we haven't done it before:
- it's nice, but not strictly required, to set our `globalOptions.target`
immediately after the `Args.fill`
- it _is_ basically required to do our mallsearches before deciding our
`globalOptions.target`
- we need to do Args.fill before we call help iff we're checking the
globalOptions object for help instead of doing a simple atring match
So there's a couple of all equally fine options to choose from for how to
reconcile this:
- move up the Args.fill, make sure that doesn't break anything
- don't ask the args object whether to display help, just check if the
argstring matches
Either of those should work
…On Tue, Jan 7, 2025, 9:05 PM Aaron McGuire ***@***.***> wrote:
@docrostov <https://github.com/docrostov> requested your review on: #2201
<#2201> moving help
above mallprices & main.php check.
—
Reply to this email directly, view it on GitHub
<#2201 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASZNQVLBZXXVL5EWZYDWGZ32JSBXVAVCNFSM6AAAAABUY4WIMGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVHA2DMMRSGM4DANI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
horrible-little-slime
requested changes
Jan 11, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
* moving help above mallprices & main.php check * move `Args.fill` to make this work --------- Co-authored-by: horrible little slime <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #garbo-dev