First pass CyberRealm #2215
Merged
First pass CyberRealm #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horrible-little-slime
requested changes
Jan 23, 2025
| { | ||
| name: "CyberRealm Overclock Fights", | ||
| ready: () => | ||
| have($item`server room key`) && // TODO support day pass? Not require tanktop |
There was a problem hiding this comment.
To support the day pass, easiest way would be to use canAdventure, right?
| ready: () => | ||
| have($item`server room key`) && // TODO support day pass? Not require tanktop | ||
| have($item`zero-trust tanktop`) && | ||
| have($skill`Torso Awareness`) && |
There was a problem hiding this comment.
I know some (unsupported) avatar paths have shirt access through another skill. Would it make more sense to use canEquip? ("No" is a perfectly fine answer here, I'm just spintballing)
| completed: () => get("_cyberFreeFights") >= 10, | ||
| do: $location`Cyberzone 1`, // TODO Support other zones with better equipment and valuing hacker drops | ||
| tentacle: false, | ||
| choices: () => ({ 1545: 1 }), // Take damage, get 0's |
There was a problem hiding this comment.
Suggested change
| choices: () => ({ 1545: 1 }), // Take damage, get 0's | |
| choices: { 1545: 1 }, // Take damage, get 0's |
doesn't matter too much, but if nothing ever changes it's nicer to not make it a function imo
github-actions bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
* First pass CyberRealm * Trash and stick are in mafia breakfast * nitpicks --------- Co-authored-by: horrible little slime <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplistic version just to use the free fights for now