Pocket wishes for the poor #2217
Conversation
| retrieveItem(yellowRay); | ||
| } | ||
| }, | ||
| do: () => wanderer().getTarget(undelay("yellow ray")), |
There was a problem hiding this comment.
| do: () => wanderer().getTarget(undelay("yellow ray")), | |
| do: () => wanderer().getTarget("yellow ray"), |
no need to undelay a value that isn't delayed??
| .externalIf( | ||
| bestYellowRay() instanceof Skill, | ||
| Macro.trySkill(bestYellowRay() as Skill), | ||
| Macro.tryItem(bestYellowRay() as Item), | ||
| ), |
There was a problem hiding this comment.
if there isn't an existing method for Item | Skills you should just make one instead of throwing an externalIf in here
| } | ||
| }, | ||
| do: () => wanderer().getTarget(undelay("yellow ray")), | ||
| outfit: () => meatTargetOutfit(), |
There was a problem hiding this comment.
This isn't a fight against our meat target and thus shouldn't use our meat target outfit. also this doesn't equip the retrocape or roman candle if they're the appropriate YR source
| @@ -955,8 +958,55 @@ const BarfTurnTasks: GarboTask[] = [ | |||
| combat: new GarboStrategy(() => Macro.meatKill()), | |||
| spendsTurn: () => globalOptions.target.attributes.includes("FREE"), | |||
| }, | |||
| { | |||
| name: "Other Yellow Rays", | |||
| ready: () => have($skill`Just the Facts`) && get("_bookOfFactsWishes") < 3, // the only way we can guarantee this is profitable | |||
There was a problem hiding this comment.
Given that there's nothing here that specifically targets pocket wishes I'm not sure this ready condition makes sense
There was a problem hiding this comment.
There's also a world--many worlds, in fact--where spending meat on a viral video has negative EV
| function bestYellowRay(): Skill | Item { | ||
| if (have($item`Roman Candelabra`)) { | ||
| return $skill`Blow the Yellow Candle!`; | ||
| } | ||
|
|
||
| if ( | ||
| have($item`Clan VIP Lounge key`) && | ||
| getClanLounge()["clan underground fireworks shop"] !== undefined | ||
| ) { | ||
| return $item`yellow rocket`; | ||
| } | ||
|
|
||
| if (RetroCape.have()) { | ||
| return $skill`Unleash the Devil's Kiss`; | ||
| } | ||
|
|
||
| if (have($skill`Disintegrate`)) { | ||
| return $skill`Disintegrate`; | ||
| } | ||
|
|
||
| return $item`viral video`; | ||
| } | ||
|
|
There was a problem hiding this comment.
This function doesn't belong here. Lib might be a better place for it.
Buying the yellow rocket requires a visitUrl hit prior to actually buying due to an ongoing bug with the fireworks shop. If this has been fixed, hooray! But I haven't heard anything about it.
No description provided.