Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional target #36

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Additional target #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e76fc5d
Removed unused using
Nyami Apr 24, 2024
4c19f6a
Add netstandard2.0 as addition target framework, also updated version…
Nyami Apr 24, 2024
8b4776f
Update run_tests.yml
Nyami Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/run_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: Run Tests

on:
workflow_dispatch:
pull_request:
types: [opened, reopened, edited]
branches:
Expand Down
2 changes: 0 additions & 2 deletions src/lob.dotnet/Client/TolerantEnumConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
using System;
using System.Linq;
using System.Text.Json.Serialization;
using Newtonsoft.Json;
using Newtonsoft.Json.Linq;

class TolerantEnumConverter : Newtonsoft.Json.JsonConverter
{
Expand Down
4 changes: 2 additions & 2 deletions src/lob.dotnet/lob.dotnet.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo><!-- setting GenerateAssemblyInfo to false causes this bug https://github.com/dotnet/project-system/issues/3934 -->
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFrameworks>netcoreapp3.1;netstandard2.0</TargetFrameworks>
<AssemblyName>lob.dotnet</AssemblyName>
<PackageId>lob.dotnet</PackageId>
<OutputType>Library</OutputType>
Expand All @@ -11,7 +11,7 @@
<AssemblyTitle>OpenAPI Library</AssemblyTitle>
<Description>A library generated from a OpenAPI spec for the Csharp language</Description>
<RootNamespace>lob.dotnet</RootNamespace>
<Version>1.1.3</Version>
<Version>1.1.4-beta</Version>
<DocumentationFile>bin\$(Configuration)\$(TargetFramework)\lob.dotnet.xml</DocumentationFile>
<RepositoryUrl>https://github.com/lob/lob-dotnet</RepositoryUrl>
<RepositoryType>git</RepositoryType>
Expand Down