Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update US Verification response fields #466

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Update US Verification response fields #466

merged 4 commits into from
Oct 20, 2023

Conversation

amaan-lob
Copy link
Contributor

Checklist

  • Up to date with main
  • All the tests are passing
    • Delete all resources created in tests
  • Prettier
  • Spectral Lint
  • npm run bundle outputs nothing suspect
  • npm run postman outputs nothing suspect

Changes

  • Adds the following fields to the US Verifications response as part of the Cycle O update from the USPS: po_box_only_flag, dpv_inactive_reason, dpv_throwback, dpv_non_delivery_day_flag, dpv_non_delivery_day_values, dpv_no_secure_location, dpv_door_not_accessible

Areas of Concern (optional)

@amaan-lob amaan-lob requested review from BennyKitchell and a team as code owners September 28, 2023 20:02
vmangwani
vmangwani approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@vmangwani vmangwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BennyKitchell
BennyKitchell suggested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@BennyKitchell BennyKitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please run the following command and commit the results

npm run bundle && npm run pretty && npm run redoc

This will bundle all of your changes and ensure everything is correct when we release.

@amaan-lob amaan-lob requested a review from a team October 18, 2023 21:16
@ajorczak-lob ajorczak-lob merged commit cd18f72 into main Oct 20, 2023
2 checks passed
@ajorczak-lob ajorczak-lob deleted the update_us_verifications_response_fields branch October 20, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BennyKitchell BennyKitchell BennyKitchell requested changes

@siddharthpant92 siddharthpant92 siddharthpant92 approved these changes

@vmangwani vmangwani vmangwani approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amaan-lob @vmangwani @siddharthpant92 @BennyKitchell @ajorczak-lob