Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GC-1725: Fixed regex for signature url #468

Merged
merged 3 commits into from
Oct 13, 2023
Merged

GC-1725: Fixed regex for signature url #468

merged 3 commits into from
Oct 13, 2023

Conversation

siddharthpant92
Copy link
Contributor

@siddharthpant92 siddharthpant92 commented Oct 12, 2023 •
edited
Loading

https://lobsters.atlassian.net/browse/GC-1725

Checklist

  • Up to date with main
  • All the tests are passing
    • Delete all resources created in tests
  • Prettier
  • Spectral Lint
  • npm run bundle outputs nothing suspect
  • npm run postman outputs nothing suspect

Changes

Areas of Concern (optional)

@siddharthpant92 siddharthpant92 requested review from BennyKitchell and a team as code owners October 12, 2023 21:13
jorgelob
jorgelob reviewed Oct 12, 2023
View reviewed changes
dist/lob-api-bundled.yml
@@ -4681,7 +4500,7 @@ components:
returned will expire in 30 days to prevent mis-sharing. Each time a GET
request is initiated, a new signed URL will be generated.
pattern: >-
^https://lob-assets\.com/(letters|postcards|bank-accounts|checks|self-mailers|cards)/[a-z]{3,4}_[a-z0-9]{15,16}(\.pdf|_thumb_[a-z]+_[0-9]+\.png)\?(version=[a-z0-9-]*&)?expires=[0-9]{10}&signature=[a-zA-Z0-9-_]+$
^https://lob-assets.com/(letters|postcards|bank-accounts|checks|self-mailers|cards)/[a-z]{3,4}_[a-z0-9]{15,16}('|_signature)(.pdf|_thumb_[a-z]+_[0-9]+.png|.png)?(version=[a-z0-9]*&)expires=[0-9]{10}&signature=[a-zA-Z0-9-_]+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭 why....

jorgelob
jorgelob approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@jorgelob jorgelob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siddharthpant92 siddharthpant92 merged commit 9bac6a3 into main Oct 13, 2023
2 checks passed
@siddharthpant92 siddharthpant92 deleted the GC-1725 branch October 13, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgelob jorgelob jorgelob approved these changes

@BennyKitchell BennyKitchell BennyKitchell approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siddharthpant92 @BennyKitchell @jorgelob