Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMB-634: Update qr code description #491

Merged
merged 5 commits into from
May 29, 2024
Merged

CMB-634: Update qr code description #491

merged 5 commits into from
May 29, 2024

Conversation

mrjamesjcho
Copy link
Contributor

Jira ticket

Remove note about qr codes not being available for legal letters and snap packs in qr code description.
Fixes #<INSERT ISSUE NUMBER HERE>

Checklist

  • Up to date with main
  • All the tests are passing
    • Delete all resources created in tests
  • Prettier
  • Spectral Lint
  • npm run bundle outputs nothing suspect
  • npm run postman outputs nothing suspect

Changes

Areas of Concern (optional)

@mrjamesjcho mrjamesjcho requested a review from a team as a code owner May 17, 2024 18:48
@mrjamesjcho mrjamesjcho requested a review from nperri6 May 17, 2024 18:48
nperri6
nperri6 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@nperri6 nperri6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird about the big diff on the docs/index.html - i am guessing that still looks normal locally?

the actual change looks good

@mrjamesjcho
Copy link
Contributor Author

mrjamesjcho commented May 17, 2024 •
edited
Loading

weird about the big diff on the docs/index.html - i am guessing that still looks normal locally?

@nperri6 yup opening the index file locally looked good

Screenshot 2024-05-17 at 12 17 19 PM

@mrjamesjcho mrjamesjcho changed the title Cmb 634 CMB-634: Update qr code description May 21, 2024
@mrjamesjcho mrjamesjcho merged commit 3c77f9c into main May 29, 2024
6 checks passed
@mrjamesjcho mrjamesjcho deleted the CMB-634 branch May 29, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthpant92 siddharthpant92 siddharthpant92 approved these changes

@nperri6 nperri6 nperri6 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrjamesjcho @nperri6 @siddharthpant92