Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMB-642: update qr_code pages property to reference snap packs #497

Merged
merged 1 commit into from
Jun 14, 2024
Merged

CMB-642: update qr_code pages property to reference snap packs #497

merged 1 commit into from
Jun 14, 2024

Conversation

sachinmurali
Copy link
Contributor

@sachinmurali sachinmurali commented Jun 14, 2024 •
edited
Loading

Fixes CMB-642

Checklist

  • Up to date with main
  • All the tests are passing
    • Delete all resources created in tests
  • Prettier
  • Spectral Lint
  • npm run bundle outputs nothing suspect
  • npm run postman outputs nothing suspect

Changes

Areas of Concern (optional)

@sachinmurali sachinmurali requested a review from a team as a code owner June 14, 2024 21:14
@sachinmurali sachinmurali requested review from a team and vmangwani June 14, 2024 21:14
samkitsheth95
samkitsheth95 approved these changes Jun 14, 2024
View reviewed changes
Copy link

@samkitsheth95 samkitsheth95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sachinmurali sachinmurali merged commit 0ea76b6 into main Jun 14, 2024
6 checks passed
@sachinmurali sachinmurali deleted the CMB-642-1 branch June 14, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgelob jorgelob jorgelob approved these changes

@samkitsheth95 samkitsheth95 samkitsheth95 approved these changes

@vmangwani vmangwani vmangwani approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sachinmurali @vmangwani @samkitsheth95 @jorgelob