Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uppercase coverage value to pass validation #176

Closed
wants to merge 1 commit into from
Closed

Uppercase coverage value to pass validation #176

wants to merge 1 commit into from

Conversation

alies-dev
Copy link

@alies-dev alies-dev commented Oct 17, 2023

Description

The PR partially solves #172 by fixing coverage value for IntlVerification object

Note, there is a similar issue with setStatus but it's not possible to solve it in such an easy way, as a described in the issue:

it's not possible to fix \OpenAPI\Client\Model\IntlVerification::setStatus on this library level: when this method accept a numeric string (e.g. 1), we don't how to properly prefix the string because there are few possible prefixes (LV, LF, LM, LU. see the screenshot above). So, the only solution is to fix server response or lose IntlVerification validation in setCoverage and setStatus methods

So, ideally both issues should be solved on server level and this PR should be rejected. But if you think it's not possible to change server response for any reasons - this PR can be merged to fix at least one issue

image

@alies-dev
Copy link
Author

alies-dev commented Nov 8, 2023

The issue with coverage field is solved on API level, closing.

But the status field issue remains unsolved so far (in short: it returns a number like "2" instead of a string like "LF2" or "LV2" or "LM2")

@alies-dev alies-dev closed this Nov 8, 2023
@alies-dev alies-dev deleted the 172-fix-coverage-validation-intl branch November 8, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant