-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GC-1944/Change Lob Address #183
Conversation
$address_editable->setAddressCity("San Francisco"); | ||
$address_editable->setAddressState("CA"); | ||
$address_editable->setAddressZip("94114"); | ||
$address_editable->setAddressCountry("US"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure if this is ok, or if I should revert it to the old format and just modify the address. For the rest of these as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was there a reason for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this was just how it was newly generated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the two are semantically equivalent. The constructor for that model class optionally takes an associative array as a parameter and there are also setters for the fields available. I'm assuming the change were updates to the mustache templates for php since this snippets file was last generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the insights Kevin!
2, // limit | ||
includeList, // include | ||
dateCreated, // dateCreated | ||
metadata, // metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New variables added to list
in multiple places as well. I can revert this as well to keep the changes limited to address, unsure if this is breaking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the tests run in this repo :)? Is there a test for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could not run the tests at all actually.. there are dependency issues Your lock file does not contain a compatible set of packages. Please run composer update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would take a little bit of work to sort out what exactly is going on and update packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar thing here ... looks like newer generation templates include examples of passing optional parameters to the list method. These are all just code samples for demonstration purposes of course and they're accurate as far as I can tell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
$address_editable->setAddressCity("San Francisco"); | ||
$address_editable->setAddressState("CA"); | ||
$address_editable->setAddressZip("94114"); | ||
$address_editable->setAddressCountry("US"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the two are semantically equivalent. The constructor for that model class optionally takes an associative array as a parameter and there are also setters for the fields available. I'm assuming the change were updates to the mustache templates for php since this snippets file was last generated.
2, // limit | ||
includeList, // include | ||
dateCreated, // dateCreated | ||
metadata, // metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar thing here ... looks like newer generation templates include examples of passing optional parameters to the list method. These are all just code samples for demonstration purposes of course and they're accurate as far as I can tell.
docs/.DS_Store
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how this got added.. will remove
056913d
to
9728c0f
Compare
9728c0f
to
e43c4c5
Compare
Description
Changing Lob's address within the SDK to the current one: 2261 Market Street STE 5668
San Francisco, CA 94114. Limited changes to address
Story
GC-1944
Related PR's
Generator
Verify