GC-2518/fixes letters tracking event validation #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanfriss
changed the title
juanfriss
commented
Mar 11, 2024
| @@ -97,8 +97,15 @@ class Letter(ModelNormal): | |||
| } | |||
|
|
|||
| validations = { | |||
| ('tracking_events',): { | |||
| 'max_items': 0, | |||
| ('template_id',): { | |||
There was a problem hiding this comment.
same sort of validation postcards or self mailers have
|
unfortunately, don't worry about the failing tests - they've been failing for a while now (you can check older PRs) |
richseviora
approved these changes
Mar 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this slack thread, given we now allow tracking event for letters, we are removing the
max_items: 0validation fromletters.tracking_eventsStory
GC-2518
Relates to https://github.com/lob/sdks_openapi_gen/pull/341