Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC-1634/design-updates #422

Merged
merged 4 commits into from
Nov 6, 2023
Merged

GC-1634/design-updates #422

merged 4 commits into from
Nov 6, 2023

Conversation

juanfriss
Copy link
Contributor

@juanfriss juanfriss commented Nov 6, 2023

JIRA

GC-1634

Description

In order to achieve these Figma designs, I needed to make some changes to the modal and badge components:

  • Modal: allow removing the section separators/dividers
  • Modal: allow a subheading
  • Badge: create a new variant for a new gradient
image image

@juanfriss juanfriss requested a review from shannamurry November 6, 2023 14:58
@juanfriss juanfriss requested a review from a team as a code owner November 6, 2023 14:58
Copy link

guardrails bot commented Nov 6, 2023

⚠️ We detected 13 security issues in this pull request:

Vulnerable Libraries (13)
Severity Details
Critical pkg:npm/@storybook/[email protected] (t) upgrade to: > 6.5.9
Critical pkg:npm/[email protected] (t) upgrade to: > 10.3.1
Medium pkg:npm/[email protected] (t) upgrade to: > 8.19.0
Critical pkg:npm/@storybook/[email protected] (t) upgrade to: > 6.5.9
Medium pkg:npm/[email protected] (t) upgrade to: > 7.11.0
Critical pkg:npm/[email protected] (t) upgrade to: > 8.2.5
Medium pkg:npm/[email protected] (t) upgrade to: > 3.2.37
Medium pkg:npm/[email protected] (t) upgrade to: 8.4.31
Critical pkg:npm/[email protected] (t) upgrade to: > 16.8.3
Critical pkg:npm/@storybook/[email protected] (t) upgrade to: > 6.5.9
High pkg:npm/[email protected] (t) upgrade to: > 3.1.6
Medium pkg:npm/[email protected] (t) upgrade to: > 8.7.1
High pkg:npm/@babel/[email protected] (t) upgrade to: > 7.18.6

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-422.d11k469e311m4w.amplifyapp.com

@juanfriss juanfriss merged commit 34e092f into main Nov 6, 2023
4 checks passed
@juanfriss juanfriss deleted the GC-1634/design-updates branch November 6, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants