Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SELF-135: Add Icon Component #439

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

NateWaldschmidt
Copy link
Contributor

@NateWaldschmidt NateWaldschmidt commented Feb 6, 2024

NOTE: This looks big because of all the icon SVGs

JIRA

Description

  • Creates a single Icon component for a guaranteed icon interface and easier additions in the future
  • Upgrades Typescript
  • Upgrades Vue
  • Adds PrimeVue

Reviewer Checklist

This section is to be filled out by reviewers

Testing

  • This code was tested by somebody other than the developer. Do not merge until this has been done.

Copy link

guardrails bot commented Feb 6, 2024

⚠️ We detected 8 security issues in this pull request:

Vulnerable Libraries (8)
Severity Details
Critical pkg:npm/[email protected] (t) upgrade to: > 16.8.3
Medium pkg:npm/[email protected] (t) upgrade to: > 8.7.1
Medium pkg:npm/[email protected] (t) upgrade to: 8.4.31
Medium pkg:npm/[email protected] upgrade to: > 3.2.47
High pkg:npm/[email protected] (t) upgrade to: > 3.1.6
Critical pkg:npm/[email protected] (t) upgrade to: > 8.2.5
Medium pkg:npm/[email protected] (t) upgrade to: > 8.19.0
Critical pkg:npm/[email protected] (t) upgrade to: > 10.3.1

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@NateWaldschmidt NateWaldschmidt force-pushed the SELF-135/add-icon-component branch from 65ed35d to 27c4e31 Compare February 6, 2024 17:40
@NateWaldschmidt NateWaldschmidt force-pushed the SELF-135/add-icon-component branch from 27c4e31 to 2293c9d Compare February 6, 2024 17:42
@NateWaldschmidt NateWaldschmidt marked this pull request as ready for review February 6, 2024 17:45
@NateWaldschmidt NateWaldschmidt requested a review from a team as a code owner February 6, 2024 17:45
@NateWaldschmidt NateWaldschmidt merged commit 97b6f65 into main Feb 6, 2024
3 of 4 checks passed
@NateWaldschmidt NateWaldschmidt deleted the SELF-135/add-icon-component branch February 6, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants