Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SELF-135: Downgrade Vue to 3.2.32 #444

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

NateWaldschmidt
Copy link
Contributor

@NateWaldschmidt NateWaldschmidt commented Feb 8, 2024

JIRA

Description

  • A later Vue 3.2 version causes unit tests to fail in dashboard-vue

Reviewer Checklist

This section is to be filled out by reviewers

Testing

  • This code was tested by somebody other than the developer. Do not merge until this has been done.

Copy link

guardrails bot commented Feb 8, 2024

⚠️ We detected 8 security issues in this pull request:

Vulnerable Libraries (8)
Severity Details
Critical pkg:npm/[email protected] (t) upgrade to: > 8.2.5
Medium pkg:npm/[email protected] (t) upgrade to: > 8.19.0
Medium pkg:npm/[email protected] (t) upgrade to: > 8.7.1
Critical pkg:npm/[email protected] (t) upgrade to: > 10.3.1
High pkg:npm/[email protected] (t) upgrade to: > 3.1.6
Medium pkg:npm/[email protected] (t) upgrade to: 8.4.31
Medium pkg:npm/[email protected] upgrade to: > 3.2.32
Critical pkg:npm/[email protected] (t) upgrade to: > 16.8.3

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-444.d11k469e311m4w.amplifyapp.com

@NateWaldschmidt NateWaldschmidt marked this pull request as ready for review February 8, 2024 14:30
@NateWaldschmidt NateWaldschmidt requested a review from a team as a code owner February 8, 2024 14:30
@juanfriss
Copy link
Contributor

and can't we upgrade Vue version in dashboard-vue?

@NateWaldschmidt
Copy link
Contributor Author

and can't we upgrade Vue version in dashboard-vue?

No, there is something with a later Vue version that causes over 100 tests to fail. @kencrim First found this when we were trying to upgrade to Vue 3.3 and thought it was something with 3.3 but it looks like it is actually something to do with a later 3.2 version

@NateWaldschmidt NateWaldschmidt merged commit 055cdd2 into main Feb 8, 2024
4 of 5 checks passed
@NateWaldschmidt NateWaldschmidt deleted the SELF-135/downgrade-vue branch February 8, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants