Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SELF-208: Add Slots to Modals #460

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

NateWaldschmidt
Copy link
Contributor

@NateWaldschmidt NateWaldschmidt commented Mar 18, 2024

JIRA

Description

  • Adds the option to utilize slots with the Modal component

Reviewer Checklist

This section is to be filled out by reviewers

Testing

  • This code was tested by somebody other than the developer. Do not merge until this has been done.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-460.d11k469e311m4w.amplifyapp.com

@NateWaldschmidt NateWaldschmidt marked this pull request as ready for review March 18, 2024 20:58
@NateWaldschmidt NateWaldschmidt requested a review from a team as a code owner March 18, 2024 20:58
@NateWaldschmidt NateWaldschmidt force-pushed the SELF-208/add-modal-slots branch from 6674361 to 9194724 Compare March 18, 2024 21:00
Copy link

guardrails bot commented Mar 18, 2024

⚠️ We detected 7 security issues in this pull request:

Vulnerable Libraries (7)
Severity Details
Critical pkg:npm/[email protected] (t) upgrade to: > 10.3.1
High pkg:npm/[email protected] (t) upgrade to: > 3.1.6
Medium pkg:npm/[email protected] (t) upgrade to: > 8.19.0
Critical pkg:npm/[email protected] (t) upgrade to: > 8.2.5
Critical pkg:npm/[email protected] (t) upgrade to: > 16.8.3
Medium pkg:npm/[email protected] (t) upgrade to: 8.4.31
Medium pkg:npm/[email protected] (t) upgrade to: > 8.7.1

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mike-r-morgan mike-r-morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully we can get to a point where we can conditionally render prop vs slot. For now, let's just get this unblocked.

@NateWaldschmidt
Copy link
Contributor Author

Hopefully we can get to a point where we can conditionally render prop vs slot. For now, let's just get this unblocked.

I updated to Juan's suggestion for the prop to be the slot fallback (i.e. Slot takes priority over prop)

@NateWaldschmidt NateWaldschmidt merged commit a3dadc6 into main Mar 19, 2024
4 of 5 checks passed
@NateWaldschmidt NateWaldschmidt deleted the SELF-208/add-modal-slots branch March 19, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants