-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SELF-208: Add Slots to Modals #460
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
6674361
to
9194724
Compare
Vulnerable Libraries (7)
More info on how to fix Vulnerable Libraries in JavaScript. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
9194724
to
636c5a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully we can get to a point where we can conditionally render prop vs slot. For now, let's just get this unblocked.
I updated to Juan's suggestion for the prop to be the slot fallback (i.e. Slot takes priority over prop) |
JIRA
Description
Modal
componentReviewer Checklist
This section is to be filled out by reviewers
Testing