Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SELF-302: Add KeyValueInput Component #514

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

NateWaldschmidt
Copy link
Contributor

@NateWaldschmidt NateWaldschmidt commented Jun 12, 2024

JIRA

Description

  • Dynamic KeyValueInput component

Screenshots

image

Reviewer Checklist

This section is to be filled out by reviewers

Testing

  • This code was tested by somebody other than the developer. Do not merge until this has been done.

Copy link

guardrails bot commented Jun 12, 2024

⚠️ We detected 6 security issues in this pull request:

Vulnerable Libraries (6)
Severity Details
Medium pkg:npm/[email protected] (t) upgrade to: > 8.19.0
Critical pkg:npm/[email protected] (t) upgrade to: > 10.3.1
High pkg:npm/[email protected] (t) upgrade to: > 3.1.6
Critical pkg:npm/[email protected] (t) upgrade to: > 8.2.5
Critical pkg:npm/[email protected] (t) upgrade to: > 16.8.3
High pkg:npm/[email protected] (t) upgrade to: > 1.53.0

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-514.d11k469e311m4w.amplifyapp.com

@NateWaldschmidt NateWaldschmidt force-pushed the SELF-302/key-value-component branch from b62589c to 41bb870 Compare June 12, 2024 14:07
Copy link

guardrails bot commented Jun 12, 2024

⚠️ We detected 6 security issues in this pull request:

Vulnerable Libraries (6)
Severity Details
High pkg:npm/[email protected] (t) upgrade to: > 3.1.6
Critical pkg:npm/[email protected] (t) upgrade to: > 16.8.3
High pkg:npm/[email protected] (t) upgrade to: > 1.53.0
Critical pkg:npm/[email protected] (t) upgrade to: > 8.2.5
Medium pkg:npm/[email protected] (t) upgrade to: > 8.19.0
Critical pkg:npm/[email protected] (t) upgrade to: > 10.3.1

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@NateWaldschmidt NateWaldschmidt force-pushed the SELF-302/key-value-component branch from 41bb870 to c36e657 Compare June 12, 2024 14:15
Copy link

guardrails bot commented Jun 12, 2024

⚠️ We detected 6 security issues in this pull request:

Vulnerable Libraries (6)
Severity Details
Critical pkg:npm/[email protected] (t) upgrade to: > 8.2.5
Critical pkg:npm/[email protected] (t) upgrade to: > 10.3.1
High pkg:npm/[email protected] (t) upgrade to: > 3.1.6
Medium pkg:npm/[email protected] (t) upgrade to: > 8.19.0
High pkg:npm/[email protected] (t) upgrade to: > 1.53.0
Critical pkg:npm/[email protected] (t) upgrade to: > 16.8.3

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@NateWaldschmidt NateWaldschmidt marked this pull request as ready for review June 12, 2024 14:23
@NateWaldschmidt NateWaldschmidt requested a review from a team as a code owner June 12, 2024 14:23
:id="`key-${index}`"
:data-testid="`uic-key-value-input-key-${index}`"
:error="Boolean(keyErrors?.[index])"
:helper-text="keyErrors?.[index]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

what are some possible keyErrors? I couldn't generate one

Copy link
Contributor Author

@NateWaldschmidt NateWaldschmidt Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No errors are generated by the component, that is to be handled by the implementation. I thought about adding errors but ultimately decided that the validity is very dependent on the implementation and thus the implementation should handle all validation

@NateWaldschmidt NateWaldschmidt force-pushed the SELF-302/key-value-component branch from c36e657 to 58af53e Compare June 12, 2024 14:54
Copy link

guardrails bot commented Jun 12, 2024

⚠️ We detected 6 security issues in this pull request:

Vulnerable Libraries (6)
Severity Details
High pkg:npm/[email protected] (t) upgrade to: > 3.1.6
High pkg:npm/[email protected] (t) upgrade to: > 1.53.0
Critical pkg:npm/[email protected] (t) upgrade to: > 8.2.5
Critical pkg:npm/[email protected] (t) upgrade to: > 16.8.3
Critical pkg:npm/[email protected] (t) upgrade to: > 10.3.1
Medium pkg:npm/[email protected] (t) upgrade to: > 8.19.0

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Copy link

guardrails bot commented Jun 13, 2024

⚠️ We detected 6 security issues in this pull request:

Vulnerable Libraries (6)
Severity Details
High pkg:npm/[email protected] (t) upgrade to: > 3.1.6
High pkg:npm/[email protected] (t) upgrade to: > 1.53.0
Critical pkg:npm/[email protected] (t) upgrade to: > 8.2.5
Critical pkg:npm/[email protected] (t) upgrade to: > 16.8.3
Critical pkg:npm/[email protected] (t) upgrade to: > 10.3.1
Medium pkg:npm/[email protected] (t) upgrade to: > 8.19.0

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@NateWaldschmidt NateWaldschmidt merged commit 48feccd into main Jun 13, 2024
4 of 5 checks passed
@NateWaldschmidt NateWaldschmidt deleted the SELF-302/key-value-component branch June 13, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants