-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SELF-302: Add KeyValueInput
Component
#514
Conversation
Vulnerable Libraries (6)
More info on how to fix Vulnerable Libraries in JavaScript. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
b62589c
to
41bb870
Compare
Vulnerable Libraries (6)
More info on how to fix Vulnerable Libraries in JavaScript. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
41bb870
to
c36e657
Compare
Vulnerable Libraries (6)
More info on how to fix Vulnerable Libraries in JavaScript. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
:id="`key-${index}`" | ||
:data-testid="`uic-key-value-input-key-${index}`" | ||
:error="Boolean(keyErrors?.[index])" | ||
:helper-text="keyErrors?.[index]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No errors are generated by the component, that is to be handled by the implementation. I thought about adding errors but ultimately decided that the validity is very dependent on the implementation and thus the implementation should handle all validation
c36e657
to
58af53e
Compare
Vulnerable Libraries (6)
More info on how to fix Vulnerable Libraries in JavaScript. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
Vulnerable Libraries (6)
More info on how to fix Vulnerable Libraries in JavaScript. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
JIRA
Description
KeyValueInput
componentScreenshots
Reviewer Checklist
This section is to be filled out by reviewers
Testing