Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SELF-302: IconButton Variant #517

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Conversation

NateWaldschmidt
Copy link
Contributor

@NateWaldschmidt NateWaldschmidt commented Jun 17, 2024

JIRA

Description

  • Adds IconButton text variant
  • Add Skeleton component

Screenshots

image

Reviewer Checklist

This section is to be filled out by reviewers

Testing

  • This code was tested by somebody other than the developer. Do not merge until this has been done.

Copy link

guardrails bot commented Jun 17, 2024

⚠️ We detected 6 security issues in this pull request:

Vulnerable Libraries (6)
Severity Details
Critical pkg:npm/[email protected] (t) upgrade to: > 16.8.3
High pkg:npm/[email protected] (t) upgrade to: > 3.1.6
Medium pkg:npm/[email protected] (t) upgrade to: > 8.19.0
High pkg:npm/[email protected] (t) upgrade to: > 1.53.0
Critical pkg:npm/[email protected] (t) upgrade to: > 10.3.1
Critical pkg:npm/[email protected] (t) upgrade to: > 8.2.5

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-517.d11k469e311m4w.amplifyapp.com

@NateWaldschmidt NateWaldschmidt force-pushed the SELF-302/icon-button-variant branch from 7e89c31 to 469dd24 Compare June 17, 2024 12:49
@NateWaldschmidt NateWaldschmidt mentioned this pull request Jun 17, 2024
1 task
@NateWaldschmidt NateWaldschmidt marked this pull request as ready for review June 17, 2024 12:49
@NateWaldschmidt NateWaldschmidt requested a review from a team as a code owner June 17, 2024 12:49
Copy link

guardrails bot commented Jun 17, 2024

⚠️ We detected 6 security issues in this pull request:

Vulnerable Libraries (6)
Severity Details
Critical pkg:npm/[email protected] (t) upgrade to: > 16.8.3
Critical pkg:npm/[email protected] (t) upgrade to: > 8.2.5
Critical pkg:npm/[email protected] (t) upgrade to: > 10.3.1
Medium pkg:npm/[email protected] (t) upgrade to: > 8.19.0
High pkg:npm/[email protected] (t) upgrade to: > 1.53.0
High pkg:npm/[email protected] (t) upgrade to: > 3.1.6

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Copy link

guardrails bot commented Jun 17, 2024

⚠️ We detected 6 security issues in this pull request:

Vulnerable Libraries (6)
Severity Details
Critical pkg:npm/[email protected] (t) upgrade to: > 16.8.3
Critical pkg:npm/[email protected] (t) upgrade to: > 8.2.5
Critical pkg:npm/[email protected] (t) upgrade to: > 10.3.1
Medium pkg:npm/[email protected] (t) upgrade to: > 8.19.0
High pkg:npm/[email protected] (t) upgrade to: > 1.53.0
High pkg:npm/[email protected] (t) upgrade to: > 3.1.6

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@shannamurry
Copy link
Contributor

Hey Nate! I'd like to make one suggestion - can we call this something more generic since we plan to build on this? Maybe like stylized button or something like that? This saves us having to change it in the dashboard later

@NateWaldschmidt
Copy link
Contributor Author

NateWaldschmidt commented Jun 17, 2024

Hey Nate! I'd like to make one suggestion - can we call this something more generic since we plan to build on this? Maybe like stylized button or something like that? This saves us having to change it in the dashboard later

Hey!
Are you referring to the name IconButton? If so, I think this can probably get combined into the Button component once we make it a bit more flexible with Icon functionality (Hoping that I can tackle that this or next week)

@NateWaldschmidt NateWaldschmidt merged commit 756c66a into main Jun 17, 2024
4 of 5 checks passed
@NateWaldschmidt NateWaldschmidt deleted the SELF-302/icon-button-variant branch June 17, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants