Major code refactor + bug fixes #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
December 4, 2020 13:49
* Undo revert for Open Screen implementation This reverts commit a24e335.
* Refactored view controller Created view model for Open Screen Created view model for Open Screen current refactor progress--should reset More refactoring of PlayView into MVVM * Fixed orientation bug
* Created Future for download task * Reorganized project; moved logic out of ProjectPicker * Expanded open screen view model * Fixed warning for LobeModel * Added support for deleting projects * Added edit button
* Created ios.yml * Added blank test scheme
* Fixed image rotation issue, ensuring image is now in correct orientation before running inference * Fixed issue where images were slightly distorted before getting processed * Fixed issue where front-facing camera inverted view on x-axis * Moved image processing task to background thread * Changed screenshot to save the image used before inference rather than the screenshot of the entire view * Stopped sending image processing for inference if no image found
* Refactored AV Capture Session logic out of view controller * Added UI for camera switcher and photo picker * Debugging mode to see image heading to inference
ellbosch
changed the title
added 2 commits
February 11, 2021 15:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges commits from the u/elbosc/main branch, minus the "Open Screen" experience.
Changes:
New README's
I've created new README files to explain the code structure. Please start from this README, feedback appreciated!
Code Diagram
The following diagram will be visible in the README in
Lobe_iOSfolder: