Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: improve validation for provider and model in parseFilesConfig #5454

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cookieY
Copy link
Contributor

@cookieY cookieY commented Jan 15, 2025

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

隐藏对未实现的rerank 及 query_mode的校验逻辑,解决现有配置参数无法通过校验的问题

📝 补充信息 | Additional Information

Copy link

vercel bot commented Jan 15, 2025

@cookieY is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @cookieY

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.93%. Comparing base (b11d08e) to head (912e42d).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/server/globalConfig/parseFilesConfig.ts 78.94% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5454      +/-   ##
==========================================
- Coverage   92.95%   92.93%   -0.02%     
==========================================
  Files         635      636       +1     
  Lines       55507    55565      +58     
  Branches     4019     4113      +94     
==========================================
+ Hits        51595    51640      +45     
- Misses       3912     3925      +13     
Flag Coverage Δ
app 92.93% <80.95%> (-0.02%) ⬇️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 15, 2025
@dosubot dosubot bot added the 🐛 Bug Something isn't working | 缺陷 label Jan 15, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 16, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working | 缺陷 size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] can't embed files to knowledge base [Bug] 智谱Embedding模型 提示向量化失败
3 participants