Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent development dependencies in production #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

byroot
Copy link

@byroot byroot commented Aug 27, 2024

This would have caught lobsters/lobsters#1312.

Of course now that they were installed, nothing will purge them, but as they get upgraded they'll be missing and won't be requireable in production.

This would have caught lobsters/lobsters#1312.

Of course now that they were installed, nothing will purge them,
but as they get upgraded they'll be missing and won't be requireable
in production.
@pushcx
Copy link
Member

pushcx commented Aug 27, 2024

I couldn't find it on stream, but now that I see without I could immediately grep it: 2586796

So I think that part of your PR is redundant. But the BUNDLE_DEPLOYMENT: "true" is new to me and probably an improvement, based on your comment. I'll have to read the docs.

As for 'nothing will purge them', I can run bundle clean in prod sometime soon.

@byroot
Copy link
Author

byroot commented Aug 27, 2024

So I think that part of your PR is redundant.

Hum. If so that doesn't explain how rubocop could possibly have been loaded in production 🤔. Unless these gems were left around following your last month change and it didn't break yet? Really weird.

@pushcx
Copy link
Member

pushcx commented Aug 27, 2024

I dumped the heap, was puzzled to see rubocop, and then added that commit to try to not load gems from the dev/test groups. It probably would've loaded anyways because I didn't run bundle clean, but I think you might be thinking of events in the wrong order.

@byroot
Copy link
Author

byroot commented Aug 27, 2024

I dumped the heap, was puzzled to see rubocop

You mean it's still there even after lobsters/lobsters@47afb30 ?

@pushcx
Copy link
Member

pushcx commented Aug 27, 2024

No, sorry, I was talking about the heaps we examined yesterday. I produced those before anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants