fix: Types in dist have incorrect imports #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often when tsconfig.json
compilerOptions.baseUrl
property is used the autocomplete of editors imports things like "util/myfile.js" instead of relatively like this "../util/myfile.js".This works when developing the project, however when the d.ts files are generated the types are not correctly resolved and the issue is silently hidden and surfaces just when the types are crutial - when user uses the package.
This change fixes that, but as you may anticipate this showed some incompletion even inside the packages here in this monorepo (code relied on some variable to be defined, but type said it can be undefined) and these issues needed to be fixed.
However nothing major, just few conditions that throw when something is undefined has been added.
Just to point out something that Im not entirely sure of as it depends on the author of the code - DecryptFn declaration (decrypt.ts in crdx package) was not generic and it made some, for me, unsolvable type issue in
Connection.ts
in the auth package hereTo solve that I made the DecryptFn generic, but according to semver it would mean a breaking change (and I dont like that frankly :D). Let me know how can we solve it differently. For now i did it quite dirty - marked the change as a patch as its, imo, a fix