Upgrade minimum-version runners and fix Docker smoke tests #33

silv-io · 2025-01-30T08:21:33Z

Motivation

Currently, we're running into two issues with the CLI build:

The macos-12 runner is deprecated, it needs to be replaced with the oldest currently supported runner: macos-13
The Ubuntu 20.04 runner is failing

Upgrade macos-12 to macos-13
Upgrade Ubuntu to 22.04 as 20.04 will be EOL in May 2025
Add a manual curl to the health endpoint before calling localstack status services as the first call now reliably takes longer than the 2s timeout defined in localstack-core/localstack/cli/localstack.py:390

alexrashed

Great rubber ducking session! Great find with the service catalog building causing the timeout 🤯 💯 🦸🏽

Upgrade minimum macOS version to 13 due to deprecation

353d434

silv-io requested a review from alexrashed January 30, 2025 08:24

Increase minimum version of ubuntu amd runner

05231bf

silv-io force-pushed the fix-cli-build branch from a372d7c to 05231bf Compare January 30, 2025 08:37

alexrashed approved these changes Jan 30, 2025

View reviewed changes

silv-io force-pushed the fix-cli-build branch from f272f55 to 3feada6 Compare January 30, 2025 09:14

Add preemptive curl

d0ae98a

silv-io force-pushed the fix-cli-build branch from 3feada6 to d0ae98a Compare January 30, 2025 09:15

silv-io changed the title ~~Fix CLI Build for 4.1 release~~ Upgrade minimum-version runners and fix Docker smoke tests Jan 30, 2025

silv-io marked this pull request as ready for review January 30, 2025 09:24

silv-io merged commit 139436a into main Jan 30, 2025
6 checks passed

silv-io deleted the fix-cli-build branch January 30, 2025 09:24