WIP: Cross-compile 213 #3363
Closed
WIP: Cross-compile 213 #3363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… imports shadowing local identifiers Signed-off-by: philvarner <[email protected]>
… scala versions Signed-off-by: philvarner <[email protected]>
Signed-off-by: philvarner <[email protected]>
…ways will be with the complex dependency chain Signed-off-by: philvarner <[email protected]>
Signed-off-by: philvarner <[email protected]>
…ent in <=2.12 and 2.13 Signed-off-by: philvarner <[email protected]>
Signed-off-by: philvarner <[email protected]>
Signed-off-by: philvarner <[email protected]>
Signed-off-by: philvarner <[email protected]>
Signed-off-by: philvarner <[email protected]>
…lt object type of ListBuffer Signed-off-by: philvarner <[email protected]>
Signed-off-by: philvarner <[email protected]>
yurique
reviewed
Mar 12, 2021
| @@ -22,7 +22,7 @@ import scala.io.Source | |||
|
|
|||
| object WKT { | |||
| private val wktResourcePath = "/proj4/wkt/epsg.properties" | |||
| lazy val parsed: Map[Int, WktCS] = records.mapValues(WKTParser.apply) | |||
| lazy val parsed: Map[Int, WktCS] = records.mapValues(WKTParser.apply).toMap | |||
There was a problem hiding this comment.
mapValues is deprecated in 2.13
Use .view.mapValues(f). A future version will include a strict version of this method (for now, .view.mapValues(f).toMap).
There was a problem hiding this comment.
Yes -- this is just to maintain backwards compatibility with 2.11 and 2.12 with the fewest changes possible. There are hundreds if not thousands of deprecation warnings when compiling with 2.13 😬
|
another thing is @scala.deprecated("Use Iterable instead of Traversable", "2.13.0")
type Traversable[+A] = scala.collection.Iterable[A] @scala.deprecated("Use IterableOnce instead of TraversableOnce", "2.13.0")
type TraversableOnce[+A] = scala.collection.IterableOnce[A] |
5 tasks
|
Thanks a lot! Closing it in favor of #3294 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Cross-compile with 2.13 for non-Spark packages
Checklist
docsguides update, if necessaryDemo
Optional. Screenshots/REPL
Notes
Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.
Closes #XXX