Migration to CE3 and other major dependencies upgrade #3389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
force-pushed
the
upd/ce3
branch
3 times, most recently
from
b7a1ea7
to
9f9ea17
Compare
pomadchin
force-pushed
the
upd/ce3
branch
5 times, most recently
from
397d191
to
e9ffc44
Compare
pomadchin
commented
Jun 27, 2022
|
|
||
| object IORuntimeTransient extends Serializable { | ||
| val ThreadsNumber: Int = Runtime.getRuntime.availableProcessors | ||
| @transient lazy val IORuntime: unsafe.IORuntime = unsafe.IORuntime.global |
There was a problem hiding this comment.
We still need a companion object to be sure the runtime init is a @transient lazy val, to ensure that it is not serialized and the instance is created per machine.
pomadchin
force-pushed
the
upd/ce3
branch
2 times, most recently
from
b82e0ed
to
301c401
Compare
pomadchin
commented
Jun 27, 2022
| @@ -74,7 +72,7 @@ object SaveToS3 { | |||
| rdd.foreachPartition { partition => | |||
| val s3client = s3Client | |||
| val requests: fs2.Stream[IO, (PutObjectRequest, RequestBody)] = | |||
| fs2.Stream.fromIterator[IO]( | |||
| fs2.Stream.fromBlockingIterator[IO]( | |||
There was a problem hiding this comment.
By the S3AsyncClient usage we may eliminate a lot of blocking calls, simplify the code, and make it more resilient, see #3467
pomadchin
force-pushed
the
upd/ce3
branch
9 times, most recently
from
a4372ef
to
f8c90c0
Compare
pomadchin
changed the title
|
If someone has any time / will to help with CQs that is very much appreciated :D |
|
I think I'm going to merge this in, and later handle CQs. It's a pretty major change so lets base all the new work on top of it.
|
|
FYI IPZilla is deprecated. See https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/wikis/Requesting-a-Review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR migrates GT to:
It is a breaking change, but we may release it as GT 3.7.0 🤷♂️
In CE3 we have a concept of
IORuntime, which incapsulates threadpools for blocking, and non blocking computations. There is no need in passing a confusingExecutionContextaround anymore.Closes #3395 and a small step towards #3388
Closes #3463
Closes #3382
I decided to bump all major dependencies in terms of this PR, including Cassandra and JTS.
CQs
Checklist