Fix RelateNG handling of empty point elements

locationtech · Jul 29, 2024 · bf71d66 · bf71d66
1 parent 0d5eac9
commit bf71d66
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 0 deletions.
diff --git a/modules/core/src/main/java/org/locationtech/jts/operation/relateng/RelateGeometry.java b/modules/core/src/main/java/org/locationtech/jts/operation/relateng/RelateGeometry.java
@@ -295,6 +295,8 @@ public List<Point> getEffectivePoints() {
     //-- only return Points not covered by another element
     List<Point> ptList = new ArrayList<Point>();
     for (Point p : ptListAll) {
+      if (p.isEmpty())
+        continue;
       int locDim = locateWithDim(p.getCoordinate());
       if (DimensionLocation.dimension(locDim) == Dimension.P) {
         ptList.add(p);

diff --git a/modules/core/src/test/java/org/locationtech/jts/operation/relateng/RelateNGGCTest.java b/modules/core/src/test/java/org/locationtech/jts/operation/relateng/RelateNGGCTest.java
@@ -208,5 +208,11 @@ public void testAdjPolygonsContainingLineAndPoint() {
     checkCoversCoveredBy(a, b, true);
   }
 
+  public void testEmptyMultiPointElements() {
+    String a = "POLYGON ((3 7, 7 7, 7 3, 3 3, 3 7))";
+    String b = "GEOMETRYCOLLECTION (MULTIPOINT (EMPTY, (5 5)), LINESTRING (1 9, 4 9))";
+    checkIntersectsDisjoint(a, b, true);
+  }
+
 
 }
diff --git a/modules/tests/src/test/resources/testxml/misc/TestRelateGC.xml b/modules/tests/src/test/resources/testxml/misc/TestRelateGC.xml
@@ -42,6 +42,27 @@
   <test><op name="within"     arg1="A" arg2="B"> false </op></test>
 </case>
 
+<case>
+  <desc>A/GC:mP with empty MultiPoint elements</desc>
+  <a>
+    POLYGON ((3 7, 7 7, 7 3, 3 3, 3 7))
+  </a>
+  <b>
+    GEOMETRYCOLLECTION (MULTIPOINT (EMPTY, (5 5)), LINESTRING (1 9, 4 9))
+  </b>
+  <test><op name="relate" arg3="0F2FF1102" arg1="A" arg2="B"> true </op></test>
+  <test><op name="contains"   arg1="A" arg2="B"> false </op></test>
+  <test><op name="coveredBy"  arg1="A" arg2="B"> false </op></test>
+  <test><op name="covers"     arg1="A" arg2="B"> false </op></test>
+  <test><op name="crosses"    arg1="A" arg2="B"> true </op></test>
+  <test><op name="disjoint"   arg1="A" arg2="B"> false </op></test>
+  <test><op name="equalsTopo" arg1="A" arg2="B"> false </op></test>
+  <test><op name="intersects" arg1="A" arg2="B"> true </op></test>
+  <test><op name="overlaps"   arg1="A" arg2="B"> false </op></test>
+  <test><op name="touches"    arg1="A" arg2="B"> false </op></test>
+  <test><op name="within"     arg1="A" arg2="B"> false </op></test>
+</case>
+
 <case>
   <desc>mA/GC:PL</desc>
   <a>