Refactor vue components #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahflee
approved these changes
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #597 . I wrote few reusable components that had repeated codes.
I also spent some time looking into making the wizard pages more reusable (i.e. using
BaseWizardReviewPage.vue, etc. which can be reused by individual platforms), however it was slightly trickier to do without knowing what the Facebook platform would ultimately look like. So I am considering to do a second pass on similar refactoring, after we implement the Facebook platform, ideally making newer platforms even more quicker. But for the time, I am leaving it at this, so we can move ahead with tests and unblock FB support work.