fix: don't pass a string as the enable_starttls_auto mailer parameter

lib/locomotive/steam.rb

@@ -32,6 +32,8 @@ module Steam
 
     IsLAYOUT  = /\Alayouts(\/|\z)/o.freeze
 
+    TRUTHY_VALUES = [1, '1', 'true', true]
+
     class << self
       attr_writer   :configuration
       attr_accessor :extension_configurations

lib/locomotive/steam/middlewares/auth.rb

@@ -175,7 +175,7 @@ def email_handle
         end
 
         def disable_email
-          [1, '1', 'true', true].include?(params[:auth_disable_email])
+          Locomotive::Steam::TRUTHY_VALUES.include?(params[:auth_disable_email])
         end
 
         def entry

lib/locomotive/steam/services/email_service.rb

@@ -32,6 +32,10 @@ def prepare_options(options, context)
 
         options[:via] ||= :smtp
         options[:via_options] ||= options.delete(:smtp).try(:symbolize_keys)
+
+        if (enable_starttls_auto = options[:via_options][:enable_starttls_auto]).present?
+          options[:via_options][:enable_starttls_auto] = Locomotive::Steam::TRUTHY_VALUES.include?(enable_starttls_auto)
+        end
       end
 
       def build_body(options, context, html = true)

spec/unit/services/email_service_spec.rb

@@ -14,7 +14,8 @@
 
   describe '#send' do
 
-    let(:smtp_options)  { { address: 'smtp.example.com', user_name: 'user', password: 'password' } }
+    let(:enable_starttls_auto) { '0' }
+    let(:smtp_options)  { { address: 'smtp.example.com', user_name: 'user', password: 'password', enable_starttls_auto: enable_starttls_auto } }
     let(:options)       { { to: '[email protected]', from: '[email protected]', subject: 'Hello world', body: 'Hello {{ to }}', smtp: smtp_options, html: false } }
     let(:context)       { ::Liquid::Context.new({ 'name' => 'John', 'to' => '[email protected]' }, {}, {}) }
 
@@ -30,12 +31,34 @@
         via_options:  {
           address:    'smtp.example.com',
           user_name:  'user',
-          password:   'password'
+          password:   'password',
+          enable_starttls_auto: false
         }
       })
       subject
     end
 
+    context "enable_starttls_auto is to '1'" do
+      let(:enable_starttls_auto) { '1' }
+
+      it 'sends the email over Pony' do
+        expect(Pony).to receive(:mail).with({
+          to:           '[email protected]',
+          from:         '[email protected]',
+          subject:      'Hello world',
+          body:         'Hello [email protected]',
+          via:          :smtp,
+          via_options:  {
+            address:    'smtp.example.com',
+            user_name:  'user',
+            password:   'password',
+            enable_starttls_auto: true
+          }
+        })
+        subject
+      end
+    end
+
     context 'simulation mode' do
 
       let(:simulation) { true }
@@ -70,7 +93,8 @@
           via_options:  {
             address:    'smtp.example.com',
             user_name:  'user',
-            password:   'password'
+            password:   'password',
+            enable_starttls_auto: false
           }
         })
         subject
@@ -110,7 +134,8 @@
             via_options:  {
               address:    'smtp.example.com',
               user_name:  'user',
-              password:   'password'
+              password:   'password',
+              enable_starttls_auto: false
             }
           })
           subject
@@ -134,7 +159,8 @@
             via_options:  {
               address:    'smtp.example.com',
               user_name:  'user',
-              password:   'password'
+              password:   'password',
+              enable_starttls_auto: false
             }
           })
           subject
@@ -154,7 +180,8 @@
               via_options:  {
                 address:    'smtp.example.com',
                 user_name:  'user',
-                password:   'password'
+                password:   'password',
+                enable_starttls_auto: false
               }
             })
             subject
@@ -179,7 +206,8 @@
             via_options:  {
               address:    'smtp.example.com',
               user_name:  'user',
-              password:   'password'
+              password:   'password',
+              enable_starttls_auto: false
             }
           })
           subject
@@ -190,9 +218,4 @@
     end
 
   end
-
-  def default_options
-
-  end
-
 end